Re: [PATCH] pcnet: fix sparse triviality

2007-10-29 Thread Kok, Auke
Jeff Garzik wrote: > Auke Kok wrote: >> Since data can never exceed u32, it can't even be larger than >> LONG_MAX/HZ. >> >> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> >> Cc: [EMAIL PROTECTED] >> --- >> > Two comments: > > 1) I would prefer to pick a sane limit, like "1 day". The unit of > 'data'

Re: [PATCH] pcnet: fix sparse triviality

2007-10-29 Thread Jeff Garzik
Auke Kok wrote: Since data can never exceed u32, it can't even be larger than LONG_MAX/HZ. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- drivers/net/pcnet32.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcnet32.c b/drivers/ne

[PATCH] pcnet: fix sparse triviality

2007-10-26 Thread Auke Kok
Since data can never exceed u32, it can't even be larger than LONG_MAX/HZ. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- drivers/net/pcnet32.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c index