On Sat, May 14, 2016 at 2:31 PM, Linus Torvalds
wrote:
>
> "u64" is indeed "unsigned long long" on x86 and many other
> architectures, but on alpha and ia64 it's just "unsigned long".
Actually, I take that back.
In the kernel, it seems to always be "unsigned long long", even on
alpha and ia64.
On Sat, May 14, 2016 at 03:21:31PM -0700, Linus Torvalds wrote:
> On Sat, May 14, 2016 at 2:33 PM, Willy Tarreau wrote:
> >
> > Why simply not cast the atomic to (unsigned long long) instead of (u64)
> > so that %llu always matches ?
>
> Yes, that fixes the problem. It's just more typing, and ann
On Sat, May 14, 2016 at 2:33 PM, Willy Tarreau wrote:
>
> Why simply not cast the atomic to (unsigned long long) instead of (u64)
> so that %llu always matches ?
Yes, that fixes the problem. It's just more typing, and annoying. The
fact that MS got it right while posix and gcc screwed it up is a
On Sat, May 14, 2016 at 02:31:04PM -0700, Linus Torvalds wrote:
> On Sat, May 14, 2016 at 11:24 AM, Linus Torvalds
> wrote:
> >
> >
> > - net->ct.slabname = kasprintf(GFP_KERNEL, "nf_conntrack_%p", net);
> > + net->ct.slabname = kasprintf(GFP_KERNEL, "nf_conntrack_%llu",
> > +
On Sat, May 14, 2016 at 11:24 AM, Linus Torvalds
wrote:
>
>
> - net->ct.slabname = kasprintf(GFP_KERNEL, "nf_conntrack_%p", net);
> + net->ct.slabname = kasprintf(GFP_KERNEL, "nf_conntrack_%llu",
> + (u64)atomic64_inc_return(&unique_id));
Oh well. I suspe
From: Linus Torvalds
Date: Sat, 14 May 2016 11:24:08 -0700 (PDT)
>
> From: Linus Torvalds
> Date: Sat, 14 May 2016 11:11:44 -0700
> Subject: [PATCH] nf_conntrack: avoid kernel pointer value leak in slab name
>
> The slab name ends up being visible in the directory structure
On Sat, 2016-05-14 at 11:24 -0700, Linus Torvalds wrote:
> From: Linus Torvalds
> Date: Sat, 14 May 2016 11:11:44 -0700
> Subject: [PATCH] nf_conntrack: avoid kernel pointer value leak in slab name
>
> The slab name ends up being visible in the directory structure under
> /sy
From: Linus Torvalds
Date: Sat, 14 May 2016 11:11:44 -0700
Subject: [PATCH] nf_conntrack: avoid kernel pointer value leak in slab name
The slab name ends up being visible in the directory structure under
/sys, and even if you don't have access rights to the file you can see
the filenames.
