On Sat, May 14, 2016 at 11:24 AM, Linus Torvalds
<torva...@linux-foundation.org> wrote:
>
>
> - net->ct.slabname = kasprintf(GFP_KERNEL, "nf_conntrack_%p", net);
> + net->ct.slabname = kasprintf(GFP_KERNEL, "nf_conntrack_%llu",
> + (u64)atomic64_inc_return(&unique_id));
Oh well. I suspect this is going to cause a new warning on alpha and
ia64 and possibly others.
"u64" is indeed "unsigned long long" on x86 and many other
architectures, but on alpga and ia64 it's just "unsigned long".
So that case should have been to "long long". I detest how there isn't
a "64-bit size" printf specifier.
And no, PRId64 preprocessor garbage and similar disgusting hacks by
POSIX isn't the answer. I think MSC actually got that right with
"%I64d".
Oh well. It's a fairly harmless compiler warning, it isn't a code
correctness issue.
Linus
