Re: [PATCH] netxen: deinline and sparse fix

Stephen Hemminger wrote: Get rid of dubious casts to (void *) which causes a sparse warning. And move largeish function from inline to the one file that uses the code, the compiler can then decide to inline it. Compile tested only. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied

Re: [PATCH] netxen: deinline and sparse fix

Yes those functions are large enough to be de-inlined. I would like to shrink those to functions, by replacing the switch blocks with a simple macros, since the mask registers are contiguous. Will repost a patch based on your patch, after a bit of testing. Thanks, -Dhananjay Stephen Hemminger wr

[PATCH] netxen: deinline and sparse fix

Get rid of dubious casts to (void *) which causes a sparse warning. And move largeish function from inline to the one file that uses the code, the compiler can then decide to inline it. Compile tested only. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h