Re: [PATCH] net: pktgen: don't abuse current->state in pktgen_thread_worker()

2015-08-06 Thread David Miller
From: Oleg Nesterov Date: Tue, 4 Aug 2015 18:33:34 +0200 > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop > code in pktgen_thread_worker()" removed (in particular) the final > __set_current_state(TASK_RUNNING) and I didn't notice the previous > set_current_state(TASK_INTERRUPTIB

Re: [PATCH] net: pktgen: don't abuse current->state in pktgen_thread_worker()

2015-08-04 Thread Marcelo Ricardo Leitner
On Tue, Aug 04, 2015 at 07:08:27PM +0200, Oleg Nesterov wrote: > On 08/04, Marcelo Ricardo Leitner wrote: > > > > On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote: > > > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop > > > code in pktgen_thread_worker()" removed (in p

Re: [PATCH] net: pktgen: don't abuse current->state in pktgen_thread_worker()

2015-08-04 Thread Oleg Nesterov
On 08/04, Marcelo Ricardo Leitner wrote: > > On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote: > > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop > > code in pktgen_thread_worker()" removed (in particular) the final > > __set_current_state(TASK_RUNNING) and I didn't n

Re: [PATCH] net: pktgen: don't abuse current->state in pktgen_thread_worker()

2015-08-04 Thread Marcelo Ricardo Leitner
On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote: > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop > code in pktgen_thread_worker()" removed (in particular) the final > __set_current_state(TASK_RUNNING) and I didn't notice the previous > set_current_state(TASK_INTERRU

[PATCH] net: pktgen: don't abuse current->state in pktgen_thread_worker()

2015-08-04 Thread Oleg Nesterov
Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop code in pktgen_thread_worker()" removed (in particular) the final __set_current_state(TASK_RUNNING) and I didn't notice the previous set_current_state(TASK_INTERRUPTIBLE). This triggers the warning in __might_sleep() after return. Af