On Tue, Aug 04, 2015 at 07:08:27PM +0200, Oleg Nesterov wrote: > On 08/04, Marcelo Ricardo Leitner wrote: > > > > On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote: > > > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop > > > code in pktgen_thread_worker()" removed (in particular) the final > > > __set_current_state(TASK_RUNNING) and I didn't notice the previous > > > set_current_state(TASK_INTERRUPTIBLE). This triggers the warning > > > in __might_sleep() after return. > > > > > > Afaics, we can simply remove both set_current_state()'s, and we > > > could do this a long ago right after ef87979c273a2 "pktgen: better > > > scheduler friendliness" which changed pktgen_thread_worker() to > > > use wait_event_interruptible_timeout(). > > > > > > Reported-by: Huang Ying <ying.hu...@intel.com> > > > Signed-off-by: Oleg Nesterov <o...@redhat.com> > > > > Interesting that it didn't happen in my tests yet per description it > > should have. Huang, did you do anything special to trigger this? > > Do you have CONFIG_DEBUG_ATOMIC_SLEEP=y ?
Ahh yes, probably not. Thanks. Marcelo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
