Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-15 Thread David Miller
From: Philipp Zabel Date: Thu, 14 Jul 2016 16:29:43 +0200 > We can't detect the FXEN (fiber mode) bootstrap pin, so configure > it via a boolean device tree property "micrel,fiber-mode". > If it is enabled, auto-negotiation is not supported. > The only available modes are 100base-fx (full duplex

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Arnd Bergmann
On Thursday, July 14, 2016 5:15:06 PM CEST Andrew Lunn wrote: > On Thu, Jul 14, 2016 at 04:33:26PM +0200, Arnd Bergmann wrote: > > On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > > > + > > > + - micrel,fiber-mode: If present the PHY is configured to operate in > > > fiber mode >

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Andrew Lunn
On Thu, Jul 14, 2016 at 04:33:26PM +0200, Arnd Bergmann wrote: > On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > > + > > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber > > mode > > + > > + Some PHYs, such as the KSZ8041FTL variant, support fiber

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Andrew Lunn
> +static int ksz8041_config_init(struct phy_device *phydev) > +{ > + /* Limit supported and advertised modes in fiber mode */ > + if (of_property_read_bool(phydev->mdio.dev.of_node, "fxen")) { > + phydev->dev_flags |= MICREL_PHY_FXEN; > + phydev->supported &= SUPPOR

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Philipp Zabel
Am Donnerstag, den 14.07.2016, 16:33 +0200 schrieb Arnd Bergmann: > On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > > + > > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber > > mode > > + > > + Some PHYs, such as the KSZ8041FTL variant, support fi

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Arnd Bergmann
On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > + > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber > mode > + > + Some PHYs, such as the KSZ8041FTL variant, support fiber mode, enabled > + by the FXEN boot strapping pin. It can't be determ

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Andrew Lunn
> > Hi Philipp > > > > Could you use a more descriptive property name? "micrel,enable-fiber"? > > "micrel,fiber-mode" ? Sure, Thanks, Andrew

[PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Philipp Zabel
We can't detect the FXEN (fiber mode) bootstrap pin, so configure it via a boolean device tree property "micrel,fiber-mode". If it is enabled, auto-negotiation is not supported. The only available modes are 100base-fx (full duplex and half duplex). Signed-off-by: Philipp Zabel --- Changes since v

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Philipp Zabel
Hi Andrew, Am Donnerstag, den 14.07.2016, 15:37 +0200 schrieb Andrew Lunn: > On Thu, Jul 14, 2016 at 12:18:48PM +0200, Philipp Zabel wrote: > > We can't detect the FXEN (fiber mode) bootstrap pin, so configure > > it via a boolean device tree property "fxen". > > Hi Philipp > > Could you use a m

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Andrew Lunn
On Thu, Jul 14, 2016 at 12:18:48PM +0200, Philipp Zabel wrote: > We can't detect the FXEN (fiber mode) bootstrap pin, so configure > it via a boolean device tree property "fxen". Hi Philipp Could you use a more descriptive property name? "micrel,enable-fiber"? Andrew

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Philipp Zabel
Hi Sergei, Am Donnerstag, den 14.07.2016, 14:35 +0300 schrieb Sergei Shtylyov: > Hello. > > On 7/14/2016 1:18 PM, Philipp Zabel wrote: > > > We can't detect the FXEN (fiber mode) bootstrap pin, so configure > > it via a boolean device tree property "fxen". If it is enabled, > > auto-negotiation

Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Sergei Shtylyov
Hello. On 7/14/2016 1:18 PM, Philipp Zabel wrote: We can't detect the FXEN (fiber mode) bootstrap pin, so configure it via a boolean device tree property "fxen". If it is enabled, auto-negotiation is not supported. The only available modes are 100base-fx (full duplex and half duplex). Signed-o

[PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support

2016-07-14 Thread Philipp Zabel
We can't detect the FXEN (fiber mode) bootstrap pin, so configure it via a boolean device tree property "fxen". If it is enabled, auto-negotiation is not supported. The only available modes are 100base-fx (full duplex and half duplex). Signed-off-by: Philipp Zabel --- I didn't see a way to reliab