Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-06 Thread Sergei Shtylyov
Hello! On 06/06/2017 04:36 PM, Antoine Tenart wrote: The mvpp22_port_mii_set() function was added by 2697582144dd, but the Need to also specify the commit summary line enclosed in (""). function directly returns without doing anything. This return was used when debugging and wasn't remov

Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-06 Thread Antoine Tenart
Hi Florian, On Tue, Jun 06, 2017 at 07:24:35AM -0700, Florian Fainelli wrote: > On 06/06/2017 06:51 AM, Antoine Tenart wrote: > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > > > >> I am wondering if we shouldn't Cc: stable as well. I don't think we > >> have seen issues on

Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-06 Thread Florian Fainelli
On 06/06/2017 06:51 AM, Antoine Tenart wrote: > Hello Thomas, > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: >> On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: >>> The mvpp22_port_mii_set() function was added by 2697582144dd, but the >>> function directly returns w

Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-06 Thread Antoine Tenart
Hello Thomas, On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > > function directly returns without doing anything. This return was used > > when

Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-06 Thread Thomas Petazzoni
Hello, On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > function directly returns without doing anything. This return was used > when debugging and wasn't removed before sending the patch. Fix this. > > Signed-off-

[PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-06 Thread Antoine Tenart
The mvpp22_port_mii_set() function was added by 2697582144dd, but the function directly returns without doing anything. This return was used when debugging and wasn't removed before sending the patch. Fix this. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 2 -- 1 file