On 06/06/2017 06:51 AM, Antoine Tenart wrote:
> Hello Thomas,
>
> On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote:
>> On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote:
>>> The mvpp22_port_mii_set() function was added by 2697582144dd, but the
>>> function directly returns without doing anything. This return was used
>>> when debugging and wasn't removed before sending the patch. Fix this.
>>>
>>> Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com>
>>
>> Please add:
>>
>> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
>>
>> with this:
>>
>> Acked-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
>
> OK, will do.
>
>> I am wondering if we shouldn't Cc: stable as well. I don't think we
>> have seen issues on our side because U-Boot does the necessary
>> initialization, but people using other bootloaders might have issues.
>
> Yes, that might be safer to cc stable. I'll do this as well.
David queues network patches for stable provided that you submit those
against his "net" tree [1] and there is an appropriate Fixes tag (which
Thomas provided).
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n114
--
Florian
