From: Atsushi Nemoto
Date: Thu, 3 Sep 2015 15:01:02 +0900
> On Wed, 2 Sep 2015 22:32:54 -0700, David Miller wrote:
>>> I think napi_gro_flush() can be called with irq enabled, so moving the
>>> spin_lock_irqsave() just before the __napi_complete() (or moving the
>>> __napi_complete() just after
On Wed, 2 Sep 2015 22:32:54 -0700, David Miller wrote:
>> I think napi_gro_flush() can be called with irq enabled, so moving the
>> spin_lock_irqsave() just before the __napi_complete() (or moving the
>> __napi_complete() just after the spin_lock_irqsave()) would be better,
>> right?
>
> It shoul
From: Atsushi Nemoto
Date: Thu, 3 Sep 2015 09:52:57 +0900
> On Wed, 2 Sep 2015 11:25:00 -0700, David Miller wrote:
>> Two lines below this change you are disabling interrupts anyways,
>> so I would suggest just moving the spin_lock_irqsave() before the
>> napi_gro_flush() to fix this.
>>
>> Man
On Thu, 2015-09-03 at 09:52 +0900, Atsushi Nemoto wrote:
> On Wed, 2 Sep 2015 11:25:00 -0700, David Miller wrote:
> > Two lines below this change you are disabling interrupts anyways,
> > so I would suggest just moving the spin_lock_irqsave() before the
> > napi_gro_flush() to fix this.
> >
> > M
On Wed, 2 Sep 2015 11:25:00 -0700, David Miller wrote:
> Two lines below this change you are disabling interrupts anyways,
> so I would suggest just moving the spin_lock_irqsave() before the
> napi_gro_flush() to fix this.
>
> Many of the checks done by napi_complete_done() (invoked by
> napi_com
From: Atsushi Nemoto
Date: Wed, 2 Sep 2015 17:49:29 +0900
> tse_poll() calls __napi_complete() with irq enabled. This leads napi
> poll_list corruption and may stop all napi drivers working.
> Use napi_complete() instead of __napi_complete().
>
> Signed-off-by: Atsushi Nemoto
Two lines below
tse_poll() calls __napi_complete() with irq enabled. This leads napi
poll_list corruption and may stop all napi drivers working.
Use napi_complete() instead of __napi_complete().
Signed-off-by: Atsushi Nemoto
---
drivers/net/ethernet/altera/altera_tse_main.c |3 +--
1 file changed, 1 insert
