From: Atsushi Nemoto <nem...@toshiba-tops.co.jp> Date: Wed, 2 Sep 2015 17:49:29 +0900
> tse_poll() calls __napi_complete() with irq enabled. This leads napi > poll_list corruption and may stop all napi drivers working. > Use napi_complete() instead of __napi_complete(). > > Signed-off-by: Atsushi Nemoto <nem...@toshiba-tops.co.jp> Two lines below this change you are disabling interrupts anyways, so I would suggest just moving the spin_lock_irqsave() before the napi_gro_flush() to fix this. Many of the checks done by napi_complete_done() (invoked by napi_complete()) are completely redundant in this context. For example, the direct __napi_complete() call is a really nice optimization because we know we are on the poll list and therefore it is not empty. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
