Re: [PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode

2019-02-18 Thread Vinod Koul
On 18-02-19, 14:36, Andrew Lunn wrote: > On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote: > > + case PHY_INTERFACE_MODE_RGMII_ID: > > + /* RGMII_ID needs internal delay. This is enabled through > > +* PORT5_PAD_CTRL for all ports, rather than individual port > > +

Re: [PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode

2019-02-18 Thread Vinod Koul
Hi Andrew, On 18-02-19, 14:33, Andrew Lunn wrote: > On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote: > > RGMII_ID specifies that we should have internal delay, so resurrect the > > delay addition routine but under the RGMII_ID mode. > > > > Fixes: 40269aa9f40a ("net: dsa: qca8k: disabl

Re: [PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode

2019-02-18 Thread Andrew Lunn
On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote: > + case PHY_INTERFACE_MODE_RGMII_ID: > + /* RGMII_ID needs internal delay. This is enabled through > + * PORT5_PAD_CTRL for all ports, rather than individual port > + * registers > +

Re: [PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode

2019-02-18 Thread Michal Vokáč
On 18. 02. 19 14:03, Vinod Koul wrote: RGMII_ID specifies that we should have internal delay, so resurrect the delay addition routine but under the RGMII_ID mode. Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode") Signed-off-by: Vinod Koul Fixes the problem on my imx6dl pla

Re: [PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode

2019-02-18 Thread Andrew Lunn
On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote: > RGMII_ID specifies that we should have internal delay, so resurrect the > delay addition routine but under the RGMII_ID mode. > > Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode") > Signed-off-by: Vinod Koul > --- >

[PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode

2019-02-18 Thread Vinod Koul
RGMII_ID specifies that we should have internal delay, so resurrect the delay addition routine but under the RGMII_ID mode. Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode") Signed-off-by: Vinod Koul --- drivers/net/dsa/qca8k.c | 12 1 file changed, 12 insertions