Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-16 Thread Nathan Rossi
On Tue, 16 Feb 2021 at 01:58, Marek Behun wrote: > > On Mon, 15 Feb 2021 15:29:44 + > Russell King - ARM Linux admin wrote: > > > On Mon, Feb 15, 2021 at 04:16:27PM +0100, Marek Behun wrote: > > > On Mon, 15 Feb 2021 14:57:57 + > > > Russell King - ARM Linux admin wrote: > > > > > > > On

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Marek Behun
On Mon, 15 Feb 2021 15:29:44 + Russell King - ARM Linux admin wrote: > On Mon, Feb 15, 2021 at 04:16:27PM +0100, Marek Behun wrote: > > On Mon, 15 Feb 2021 14:57:57 + > > Russell King - ARM Linux admin wrote: > > > > > On Mon, Feb 15, 2021 at 02:47:56PM +0100, Marek Behun wrote: > >

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Russell King - ARM Linux admin
On Mon, Feb 15, 2021 at 04:16:27PM +0100, Marek Behun wrote: > On Mon, 15 Feb 2021 14:57:57 + > Russell King - ARM Linux admin wrote: > > > On Mon, Feb 15, 2021 at 02:47:56PM +0100, Marek Behun wrote: > > > On Mon, 15 Feb 2021 06:15:59 + > > > Nathan Rossi wrote: > > > > > > > diff --

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Marek Behun
On Mon, 15 Feb 2021 14:57:57 + Russell King - ARM Linux admin wrote: > On Mon, Feb 15, 2021 at 02:47:56PM +0100, Marek Behun wrote: > > On Mon, 15 Feb 2021 06:15:59 + > > Nathan Rossi wrote: > > > > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > > > b/drivers/net/dsa/mv88e6xxx/chi

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Andrew Lunn
> If we can't switch between 1000base-X and 2500base-X, then we should > not be calling phylink_helper_basex_speed() - and only one of those > two capabilities should be set in the validation callback. I thought > there were DSA switches where we could program the CMODE to switch > between these tw

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Russell King - ARM Linux admin
On Mon, Feb 15, 2021 at 02:47:56PM +0100, Marek Behun wrote: > On Mon, 15 Feb 2021 06:15:59 + > Nathan Rossi wrote: > > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > > b/drivers/net/dsa/mv88e6xxx/chip.c > > index 54aa942eed..5c52906b29 100644 > > --- a/drivers/net/dsa/mv88e6xxx/chip.c >

Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-15 Thread Marek Behun
On Mon, 15 Feb 2021 06:15:59 + Nathan Rossi wrote: > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > b/drivers/net/dsa/mv88e6xxx/chip.c > index 54aa942eed..5c52906b29 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.c > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > @@ -650,6 +650,13 @@ static void m

[PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-14 Thread Nathan Rossi
From: Nathan Rossi The mv88e6xxx devices cannot automatically select between 1000BASE-X and 2500BASE-X and rely on configuration (gpio pins Px_SMODE/S_MODE and/or OF phy-mode) to select between the two modes. However when configuring a cpu/dsa port as 1000BASE-X with a inband or fixed link phy t