Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Dinh Nguyen
On Sat, 17 Oct 2015, Dinh Nguyen wrote: > On Sat, 17 Oct 2015, Andrew Lunn wrote: > > > > Sure, will try to debug. It looks like phydev->attached_dev is valid, but > > > phydev->attached_dev->dev.of_node is NULL. > > > > Humm > > > > phydev->attached_dev is a net_device, so should be the mac.

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Dinh Nguyen
On Sat, 17 Oct 2015, Andrew Lunn wrote: > > Sure, will try to debug. It looks like phydev->attached_dev is valid, but > > phydev->attached_dev->dev.of_node is NULL. > > Humm > > phydev->attached_dev is a net_device, so should be the mac. What > device is phydev->attached_dev->dev? Is it not the

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Andrew Lunn
> Sure, will try to debug. It looks like phydev->attached_dev is valid, but > phydev->attached_dev->dev.of_node is NULL. Humm phydev->attached_dev is a net_device, so should be the mac. What device is phydev->attached_dev->dev? Is it not the dev embedded in the platform_device passed to socfpga_

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Sergei Shtylyov
On 10/17/2015 2:54 AM, Andrew Lunn wrote: Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." broke finding PHY properties in the MAC device tree You probably forgot to run checkpatch.pl on this patch, else it would have complained about the commit citi

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Sergei Shtylyov
On 10/17/2015 2:54 AM, Andrew Lunn wrote: Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." broke finding PHY properties in the MAC device tree You probably forgot to run checkpatch.pl on this patch, else it would have complained about the commit citi

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Florian Fainelli
2015-10-17 8:06 GMT-07:00 Dinh Nguyen : > On Sat, 17 Oct 2015, Dinh Nguyen wrote: > >> On Fri, 16 Oct 2015, Andrew Lunn wrote: >> >> > On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote: >> > > On Fri, 16 Oct 2015, Andrew Lunn wrote: >> > > >> > > > Commit "8b63ec1837fa phylib: Make PHYs c

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Andrew Lunn
> I've also tried creating a separate phy node in the DTS and have the EMAC > point the PHY with a 'phy = <&phy0>;', but that also didn't seem to work with > your patch. Do you have the phy node as a child of the mdio node? Picking a random example arch/arm/boot/dts/kirkwood-rd88f6192.dts &mdio

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Dinh Nguyen
On Sat, 17 Oct 2015, Dinh Nguyen wrote: > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote: > > > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > > > > > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > > > > the bus'

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 Thread Dinh Nguyen
On Fri, 16 Oct 2015, Andrew Lunn wrote: > On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote: > > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > > > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > > > the bus' parent." broke finding PHY properties in the MAC devic

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-16 Thread Andrew Lunn
On Sat, Oct 17, 2015 at 02:32:30AM +0300, Sergei Shtylyov wrote: > On 10/16/2015 11:49 PM, Andrew Lunn wrote: > > >Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > >the bus' parent." broke finding PHY properties in the MAC device tree > >You probably forgot to run chec

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-16 Thread Andrew Lunn
On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote: > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > > the bus' parent." broke finding PHY properties in the MAC device tree > > node. The parent device is now the MDIO

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-16 Thread Sergei Shtylyov
On 10/16/2015 11:49 PM, Andrew Lunn wrote: Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." broke finding PHY properties in the MAC device tree You probably forgot to run checkpatch.pl on this patch, else it would have complained about the commit cit

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-16 Thread Dinh Nguyen
On Fri, 16 Oct 2015, Andrew Lunn wrote: > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > the bus' parent." broke finding PHY properties in the MAC device tree > node. The parent device is now the MDIO bus, not the MAC. Use > attached_dev towards the MAC device tree node.

[PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-16 Thread Andrew Lunn
Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." broke finding PHY properties in the MAC device tree node. The parent device is now the MDIO bus, not the MAC. Use attached_dev towards the MAC device tree node. Fixes: 8b63ec1837fa ("phylib: Make PHYs children