On Fri, 16 Oct 2015, Andrew Lunn wrote:
> On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote:
> > On Fri, 16 Oct 2015, Andrew Lunn wrote:
> >
> > > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not
> > > the bus' parent." broke finding PHY properties in the MAC device tree
> > > node. The parent device is now the MDIO bus, not the MAC. Use
> > > attached_dev towards the MAC device tree node.
> > >
> > > Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
> > > the bus' parent.")
> > > Signed-off-by: Andrew Lunn <and...@lunn.ch>
> > > ---
> > >
> > > Compile tested only.
> > >
> > > Dinh, please could you test it and report back if it works or not.
> > >
> >
> > This patch did not seem to fix the problem. The following code did seem to
> > fix the problem:
> >
> > if (!of_node && dev->parent->of_node)
> > - of_node = dev->parent->of_node;
> > + do {
> > + of_node = dev->of_node;
> > + dev = dev->parent;
> > + i++;
> > + } while (!of_node && dev);
>
> This might fix the issue, but it has disadvantages. As i said before,
> it allows people to place phy properties into the mdio device node. We
> want to be reducing placing you can add phy properties, not adding
> more.
>
> Please could you try to debug why my patch did not work. Is
> attached_dev null?
>
Sure, will try to debug. It looks like phydev->attached_dev is valid, but
phydev->attached_dev->dev.of_node is NULL.
BR,
Dinh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
