From: Alex
Date: Mon, 14 Nov 2016 13:54:57 -0800
>
>
> On 11/14/2016 01:25 PM, Florian Fainelli wrote:
>> On 11/14/2016 01:18 PM, David Miller wrote:
>>> From: Alexandru Gagniuc
>>> Date: Sat, 12 Nov 2016 15:32:13 -0800
>>>
+ if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
+
On 11/14/2016 01:25 PM, Florian Fainelli wrote:
On 11/14/2016 01:18 PM, David Miller wrote:
From: Alexandru Gagniuc
Date: Sat, 12 Nov 2016 15:32:13 -0800
+ if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
+ ret = vsc8601_add_skew(phydev);
I think you should use ph
On 11/14/2016 01:18 PM, David Miller wrote:
> From: Alexandru Gagniuc
> Date: Sat, 12 Nov 2016 15:32:13 -0800
>
>> +if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
>> +ret = vsc8601_add_skew(phydev);
>
> I think you should use phy_interface_is_rgmii() here.
>
This would i
From: Alexandru Gagniuc
Date: Sat, 12 Nov 2016 15:32:13 -0800
> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
> + ret = vsc8601_add_skew(phydev);
I think you should use phy_interface_is_rgmii() here.
With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The
VSC8601 can handle this internally. While the VSC8601 can set more
fine-grained delays, the standard skew settings work out of the box.
The same heuristic is used to determine when this skew should be enabled
as in vsc824x_conf
