On 11/14/2016 01:18 PM, David Miller wrote: > From: Alexandru Gagniuc <ale...@adaptrum.com> > Date: Sat, 12 Nov 2016 15:32:13 -0800 > >> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) >> + ret = vsc8601_add_skew(phydev); > > I think you should use phy_interface_is_rgmii() here. >
This would include all RGMII modes, here I think the intent is to check for PHY_INTERFACE_MODE_RGMII_ID and PHY_INTERFACE_MODE_RGMII_TXID (or RXID), Alexandru, what direction does the skew settings apply to? -- Florian
