Re: [PATCH] mii: check carrier state even when force_media == 1

2006-01-24 Thread Denis Vlasenko
On Tuesday 24 January 2006 23:12, Jeff Garzik wrote: > On Tue, Jan 24, 2006 at 03:50:09PM -0500, John W. Linville wrote: > > Drivers using mii_check_media (via-rhine in particular) and also > > forcing link parameters with ethtool can reach a state where the link > > goes down and never comes back

Re: [PATCH] mii: check carrier state even when force_media == 1

2006-01-24 Thread Jeff Garzik
On Tue, Jan 24, 2006 at 03:50:09PM -0500, John W. Linville wrote: > Drivers using mii_check_media (via-rhine in particular) and also > forcing link parameters with ethtool can reach a state where the link > goes down and never comes back up. This is because mii_check_media > short-circuits early i

[PATCH] mii: check carrier state even when force_media == 1

2006-01-24 Thread John W. Linville
Drivers using mii_check_media (via-rhine in particular) and also forcing link parameters with ethtool can reach a state where the link goes down and never comes back up. This is because mii_check_media short-circuits early if mii->force_media != 0. This was discussed in a couple of past threads,