On Tuesday 24 January 2006 23:12, Jeff Garzik wrote: > On Tue, Jan 24, 2006 at 03:50:09PM -0500, John W. Linville wrote: > > Drivers using mii_check_media (via-rhine in particular) and also > > forcing link parameters with ethtool can reach a state where the link > > goes down and never comes back up. This is because mii_check_media > > short-circuits early if mii->force_media != 0. This was discussed > > in a couple of past threads, one of which is available here: > > > > http://www.ussg.iu.edu/hypermail/linux/kernel/0508.3/0670.html > > > > The patch moves the force_media check to below the carrier status > > check. This allows the link state to show correctly, while avoiding > > the check of link parameters. > > The entire point of force_media is that you don't check carrier status, > its assumed to always be up... > > As I noted in a couple threads, if force_media is set, the driver should > call netif_carrier_on() and then never call a function that causes the > carrier state to change. The existing mii.c logic follows this.
I don't have an opinion on this. If you say so, let it be so. I just did all needed bug hunting, and would like it fixed. Am I asking for too much? Please communicate your verdict to relevant driver maintainers. The breakage persists for 2 or 3 kernel releases even after the reason was diagnosed. It's becoming silly. -- vda - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
