Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread Jeff Kirsher
On Fri, 2019-01-04 at 15:09 +, Steve Douthit wrote: > On 1/3/19 7:55 PM, Jeff Kirsher wrote: > > I initially tried that, but we get a recursive Kconfig dependency > > error > > when IPSec is enabled as well, which I noted in the commit message. > I'm not running into the dependency issue you me

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread Steve Douthit
On 1/3/19 7:55 PM, Jeff Kirsher wrote: > I initially tried that, but we get a recursive Kconfig dependency error > when IPSec is enabled as well, which I noted in the commit message. I'm not running into the dependency issue you mention in my own testing of the 'select PHYLIB' patch. All of the fo

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Jeff Kirsher
On Fri, 2019-01-04 at 00:00 +, Steve Douthit wrote: > Just tested this against a DSA dev in hardware and it works, but I > still think the simpler solution would be to just select PHYLIB: > > diff --git a/drivers/net/ethernet/intel/Kconfig > b/drivers/net/ethernet/intel/Kconfig > index 31fb76e

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Steve Douthit
On 1/3/19 4:35 PM, Jeff Kirsher wrote: > The new ability added to the driver to use mii_bus to handle MII related > ioctls is causing compile issues when the driver is compiled into the > kernel (i.e. not a module). > > The simple solution of requiring the driver to be compiled as a module when >

RE: [Intel-wired-lan] [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Bowers, AndrewX
ubject: [Intel-wired-lan] [PATCH] ixgbe: fix Kconfig when driver is not a > module > > The new ability added to the driver to use mii_bus to handle MII related > ioctls is causing compile issues when the driver is compiled into the kernel > (i.e. not a module). > > The simple so

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Jeff Kirsher
On Thu, 2019-01-03 at 13:35 -0800, Jeff Kirsher wrote: > The new ability added to the driver to use mii_bus to handle MII > related > ioctls is causing compile issues when the driver is compiled into the > kernel (i.e. not a module). > > The simple solution of requiring the driver to be compiled a

[PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-03 Thread Jeff Kirsher
The new ability added to the driver to use mii_bus to handle MII related ioctls is causing compile issues when the driver is compiled into the kernel (i.e. not a module). The simple solution of requiring the driver to be compiled as a module when MDIO_BUS is a module, causes a recursion Kconfig is