"David S. Miller" <[EMAIL PROTECTED]> writes:
> From: [EMAIL PROTECTED] (Eric W. Biederman)
> Date: Wed, 25 Jan 2006 13:08:53 -0700
>
>> Analysis:
>> Currently tcp_v6_send_synack is never called with a dst entry
>> so dst always comes in as NULL.
>>
>> ip6_dst_lookup calls ip6_route_output which
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 1 Feb 2006 12:53:02 +1100
> In that case, every rtx_syn_ack function needs to do a dst_release
> on the supplied dst if it's not NULL. So we need Eric's fix plus
> the same fix applied to dccp6.
I've done that in my net-2.6 tree.
-
To unsubscribe f
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Wed, 25 Jan 2006 13:08:53 -0700
> Analysis:
> Currently tcp_v6_send_synack is never called with a dst entry
> so dst always comes in as NULL.
>
> ip6_dst_lookup calls ip6_route_output which calls dst_hold
> before it returns the dst entry. Neith
On Tue, Jan 31, 2006 at 05:34:16PM -0800, David S. Miller wrote:
>
> Actually, we can't kill off that arg so simply.
> TCP ipv4 sends in a non-NULL dst to it's tcp_v4_send_synack()
> via tcp_v4_conn_request() when timewait recycling is enabled.
Oops I only grepped for rtx_syn_ack as opposed to th
From: "David S. Miller" <[EMAIL PROTECTED]>
Date: Tue, 31 Jan 2006 17:29:10 -0800 (PST)
> Regardless, since everyone passes NULL as the dst argument
> to ->rtx_syn_ack() I am going to kill that argument off now
> before it causes any troubles and then put in Eric's fix
> (after thinking about it s
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jan 2006 13:42:02 +1100
> Eric W. Biederman <[EMAIL PROTECTED]> wrote:
> >
> > This patch fix dst reference counting in tcp_v6_send_synack
> >
> > Analysis:
> > Currently tcp_v6_send_synack is never called with a dst entry
> > so dst always come
Eric W. Biederman <[EMAIL PROTECTED]> wrote:
>
> This patch fix dst reference counting in tcp_v6_send_synack
>
> Analysis:
> Currently tcp_v6_send_synack is never called with a dst entry
> so dst always comes in as NULL.
Thanks for the bug fix. BTW, why don't we get rid of the dst
argument to r
This patch fix dst reference counting in tcp_v6_send_synack
Analysis:
Currently tcp_v6_send_synack is never called with a dst entry
so dst always comes in as NULL.
ip6_dst_lookup calls ip6_route_output which calls dst_hold
before it returns the dst entry. Neither xfrm_lookup
nor tcp_make_synac
