On Tue, Jan 31, 2006 at 05:34:16PM -0800, David S. Miller wrote: > > Actually, we can't kill off that arg so simply. > TCP ipv4 sends in a non-NULL dst to it's tcp_v4_send_synack() > via tcp_v4_conn_request() when timewait recycling is enabled.
Oops I only grepped for rtx_syn_ack as opposed to the functions themselves. I suppose we do want to keep this optimisation. In that case, every rtx_syn_ack function needs to do a dst_release on the supplied dst if it's not NULL. So we need Eric's fix plus the same fix applied to dccp6. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html