Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Arnd Bergmann
On Wednesday 29 July 2015 11:02:41 Scott Wood wrote: > On Wed, 2015-07-29 at 10:02 +0200, Arnd Bergmann wrote: > > On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: > > > +#ifdef CONFIG_PM > > > static void lock_tx_qs(struct gfar_private *priv) > > > { > > > int i; > > > @@ -580,6 +581,7 @

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Scott Wood
On Wed, 2015-07-29 at 10:02 +0200, Arnd Bergmann wrote: > On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: > > +#ifdef CONFIG_PM > > static void lock_tx_qs(struct gfar_private *priv) > > { > > int i; > > @@ -580,6 +581,7 @@ static void unlock_tx_qs(struct gfar_private *priv) > > for (

RE: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Manoil Claudiu
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, July 29, 2015 11:02 AM > To: linuxppc-...@lists.ozlabs.org; netdev@vger.kernel.org; Manoil Claudiu- > B08782; Wood Scott-B07421 > Subject: Re: [PATCH] gianfar: Fix warnings when built

RE: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Manoil Claudiu
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, July 29, 2015 11:02 AM > To: linuxppc-...@lists.ozlabs.org; netdev@vger.kernel.org; Manoil Claudiu- > B08782; Wood Scott-B07421 > Subject: Re: [PATCH] gianfar: Fix warnings when built

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Arnd Bergmann
On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: > Alternatively, if there's a desire to not mess with this code (I don't > know how to trigger this code path to test it), this driver should be > given dependencies that ensure that it only builds on 32-bit. These are obvious fixes, they shoul

[PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-28 Thread Scott Wood
As part of defconfig consolidation using fragments, we'd like to be able to have the same drivers enabled on 32-bit and 64-bit. Gianfar happens to only exist on 32-bit systems, and when building the resulting 64-bit kernel warnings were produced. A couple of the warnings are trivial, but the rfbp