Re: [PATCH] d80211: don't symlink empty default keys

2007-01-10 Thread Jiri Benc
On Wed, 10 Jan 2007 21:05:28 +0100, Jan Kiszka wrote: > Hmm, is this required? Will sysfs_remove_link panic on non-existent > nodes? No, it won't. > If yes or if it's considered better style, I consider it a better style as it's more tolerant to possible changes in sysfs_remove_link. > are you

Re: [PATCH] d80211: don't symlink empty default keys

2007-01-10 Thread Jan Kiszka
Jiri Benc wrote: > On Tue, 09 Jan 2007 23:33:34 +0100, Jan Kiszka wrote: >> This gets rid of annoying >> >> wlan0: cannot create symlink to default key >> >> in my syslog with latest rt2x00. The patch takes care that in case of >> (key/old_key == NULL && set_tx_key) the existing default key symlink

Re: [PATCH] d80211: don't symlink empty default keys

2007-01-10 Thread Jiri Benc
On Tue, 09 Jan 2007 23:33:34 +0100, Jan Kiszka wrote: > This gets rid of annoying > > wlan0: cannot create symlink to default key > > in my syslog with latest rt2x00. The patch takes care that in case of > (key/old_key == NULL && set_tx_key) the existing default key symlink is > removed correctly

Re: [PATCH] d80211: don't symlink empty default keys

2007-01-09 Thread Jan Kiszka
Jan Kiszka wrote: > This gets rid of annoying > > wlan0: cannot create symlink to default key > > in my syslog with latest rt2x00. The patch takes care that in case of > (key/old_key == NULL && set_tx_key) the existing default key symlink is > removed correctly. Moreover, it tests for key!=NULL b

[PATCH] d80211: don't symlink empty default keys

2007-01-09 Thread Jan Kiszka
This gets rid of annoying wlan0: cannot create symlink to default key in my syslog with latest rt2x00. The patch takes care that in case of (key/old_key == NULL && set_tx_key) the existing default key symlink is removed correctly. Moreover, it tests for key!=NULL before trying to register a new d