Re: [PATCH] cleanup of the NETIF_F_* flag definitions

2006-08-13 Thread Herbert Xu
Jeff Garzik <[EMAIL PROTECTED]> wrote: > Peter Zijlstra wrote: >> Cleanup the NETIF_F_ flag definitions >> >> Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > > If you are going to do a cleanup here, you should use the form that > makes it _immediately_ obvious which bit(s) are being used: A

Re: [PATCH] cleanup of the NETIF_F_* flag definitions

2006-08-12 Thread Jeff Garzik
Peter Zijlstra wrote: Cleanup the NETIF_F_ flag definitions Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> If you are going to do a cleanup here, you should use the form that makes it _immediately_ obvious which bit(s) are being used: #define NETIF_F_SG (1 << 0) #define NETIF_F_IP_C

[PATCH] cleanup of the NETIF_F_* flag definitions

2006-08-12 Thread Peter Zijlstra
Cleanup the NETIF_F_ flag definitions Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/netdevice.h | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) Index: linux-2.6/include/linux/netdevice.h