Peter Zijlstra wrote:
Cleanup the NETIF_F_ flag definitions

Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]>

If you are going to do a cleanup here, you should use the form that makes it _immediately_ obvious which bit(s) are being used:

#define NETIF_F_SG      (1 << 0)
#define NETIF_F_IP_CSUM (1 << 1)
#define NETIF_F_NO_CSUM (1 << 2)
[...]

Maybe DaveM's brain automatically translates all hex numbers into bit numbers, but not everybody's brain works that way... :) It is better to use a form that requires no human brain translation...

        Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to