Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-20 Thread Florian Fainelli
On 09/20/2017 02:27 PM, ros...@gmail.com wrote: > Sorry for the noise. After more testing I've found out that the cause > was that I had BBR enabled on my laptop. Switching back to CUBIC fixed > the issue. > > In other words, this patch is detrimental. Quite unsurprisingly, thanks for coming back

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-20 Thread rosenp
Sorry for the noise. After more testing I've found out that the cause was that I had BBR enabled on my laptop. Switching back to CUBIC fixed the issue. In other words, this patch is detrimental. ~67mbps - gro off ~87mbps - gro on On Fri, 2017-09-15 at 23:04 -0700, Florian Fainelli wrote: > On Se

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread Florian Fainelli
On September 15, 2017 5:38:42 PM PDT, ros...@gmail.com wrote: >I have not. Unfortunately I own no gigabit hardware to test this on. >The MIPS CPU runs at 300MHz on my unit. > bgmac is used on Gigabit capable hardware, like Northstar and Northstar Plus, and others too, so unless you can get access

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread David Miller
From: Eric Dumazet Date: Fri, 15 Sep 2017 17:03:30 -0700 > On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote: >> On September 15, 2017 3:22:18 PM PDT, Rosen Penev >> wrote: >> >On a linksys E1200v1 (actually a crossflashed E1000v2), the >> offloading >> >features give no measurable benef

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread rosenp
I have not. Unfortunately I own no gigabit hardware to test this on. The MIPS CPU runs at 300MHz on my unit. On Fri, 2017-09-15 at 17:34 -0700, Eric Dumazet wrote: > On Fri, 2017-09-15 at 17:23 -0700, Rosen Penev wrote: > > On a linksys E1200v1 (actually a crossflashed E1000v2), the > > offloading

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread Eric Dumazet
On Fri, 2017-09-15 at 17:23 -0700, Rosen Penev wrote: > On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading > features give no measurable benefit to speed or latency. Furthermore, > disabling GRO actually improves iperf performance by a whoppimg 3mbps. > Results: > > Currentl

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread Denys Fedoryshchenko
On 2017-09-16 03:18, Eric Dumazet wrote: On Fri, 2017-09-15 at 17:10 -0700, ros...@gmail.com wrote: Ok fair enough. Will only disable GRO in the driver. Well, do not even try. NETIF_F_SOFT_FEATURES is set by core networking stack in register_netdevice(), ( commit 212b573f5552c60265da721ff9ce3

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread rosenp
netif_receive_skb seems to have the same effect as "ethtool -K eth0 gro off". On Fri, 2017-09-15 at 17:18 -0700, Eric Dumazet wrote: > On Fri, 2017-09-15 at 17:10 -0700, ros...@gmail.com wrote: > > Ok fair enough. Will only disable GRO in the driver. > > Well, do not even try. > > NETIF_F_SOFT_F

[PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread Rosen Penev
On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading features give no measurable benefit to speed or latency. Furthermore, disabling GRO actually improves iperf performance by a whoppimg 3mbps. Results: Currently: [ 4] local 192.168.1.1 port 5001 connected with 192.168.1.100

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread Eric Dumazet
On Fri, 2017-09-15 at 17:10 -0700, ros...@gmail.com wrote: > Ok fair enough. Will only disable GRO in the driver. Well, do not even try. NETIF_F_SOFT_FEATURES is set by core networking stack in register_netdevice(), ( commit 212b573f5552c60265da721ff9ce32e3462a2cdd ) Absolutely no driver disable

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread rosenp
Ok fair enough. Will only disable GRO in the driver. Tests were done using "ethtool -K eth0 gro off" and on. On Fri, 2017-09-15 at 17:03 -0700, Eric Dumazet wrote: > On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote: > > On September 15, 2017 3:22:18 PM PDT, Rosen Penev > > > > wrote: >

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread Eric Dumazet
On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote: > On September 15, 2017 3:22:18 PM PDT, Rosen Penev > wrote: > >On a linksys E1200v1 (actually a crossflashed E1000v2), the > offloading > >features give no measurable benefit to speed or latency. Furthermore, > >disabling GRO actually imp

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread rosenp
you're absolutely correct. will send an updated version shortly. On Fri, 2017-09-15 at 16:14 -0700, David Miller wrote: > From: Rosen Penev > Date: Fri, 15 Sep 2017 15:22:18 -0700 > > > On a linksys E1200v1 (actually a crossflashed E1000v2), the > offloading features give no measurable benefit t

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread David Miller
From: Rosen Penev Date: Fri, 15 Sep 2017 15:22:18 -0700 > On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading > features give no measurable benefit to speed or latency. Furthermore, > disabling GRO actually improves iperf performance by a whoppimg 3mbps. > Results: ... > -

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread Florian Fainelli
On September 15, 2017 3:22:18 PM PDT, Rosen Penev wrote: >On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading >features give no measurable benefit to speed or latency. Furthermore, >disabling GRO actually improves iperf performance by a whoppimg 3mbps. Do you have a way to gene

[PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-15 Thread Rosen Penev
On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading features give no measurable benefit to speed or latency. Furthermore, disabling GRO actually improves iperf performance by a whoppimg 3mbps. Results: Currently: [ 4] local 192.168.1.1 port 5001 connected with 192.168.1.100