From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Thu, 22 Feb 2007 11:43:32 +0100
> I wonder if :
>
> newtp->snd_nxt = newtp->snd_una = newtp->snd_sml = treq->snt_isn + 1;
>
> is correct, since compiler will write snd_sml, then snd_una, and snd_nxt
>
> Maybe we should also reorder this too ?
Yes, t
On Thursday 22 February 2007 11:32, David Miller wrote:
> From: Eric Dumazet <[EMAIL PROTECTED]>
> Date: Thu, 22 Feb 2007 11:22:02 +0100
>
> > rcv_wup and copied_seq should be next to rcv_nxt field, to lower number
> > of active cache lines in hot paths. (tcp_rcv_established(), tcp_poll(),
> > ...)
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Thu, 22 Feb 2007 11:22:02 +0100
> rcv_wup and copied_seq should be next to rcv_nxt field, to lower number of
> active cache lines in hot paths. (tcp_rcv_established(), tcp_poll(), ...)
Please fixup the assignment order in tcp_create_openreq_child() el
Hi David
I noticed in oprofile study a cache miss in tcp_rcv_established() to read
copied_seq.
80400a80 : /* tcp_rcv_established total: 4034293
2.0400 */
55493 0.0281 :80400bc9: mov0x4c8(%r12),%eax copied_seq
543103 0.2746 :80400bd1: cmp0x3e0(%r12),%eax
