Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 03 Oct 2006 20:05:33 +0200 > Ismail Donmez wrote: > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > > changed behaviour so it returns true when the node is empty as expected. > > Hence Patrick McHardy's fix for sc

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

Ismail Donmez wrote: > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > changed behaviour so it returns true when the node is empty as expected. > Hence Patrick McHardy's fix for sched_htb.c should be reverted. > > Signed-off-by: Ismail Donmez <[EMAIL PROTECTED]> ACKe

[PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns true when the node is empty as expected. Hence Patrick McHardy's fix for sched_htb.c should be reverted. Signed-off-by: Ismail Donmez <[EMAIL PROTECTED]> diff --git a/net/sched/sch_htb.c b/n

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Tue, Oct 03, 2006 at 12:28:32PM +0200, Jens Axboe wrote: ... > I don't see any missed changes. And you are right! I've checked the link from the first message of this thread and now I see it's not current enough. I'm sorry for this false alarm. Jarek P. - To unsubscribe from this list: send

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Mon, Oct 02 2006, Ismail Donmez wrote: > 02 Eki 2006 Pts 13:24 tarihinde, Jarek Poplawski ??unlar?? yazmt??: > > On 30-09-2006 21:23, Ismail Donmez wrote: > > > Hi, > > > > > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > > > changed behaviour so it returns fa

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Mon, Oct 02 2006, Jarek Poplawski wrote: > On Mon, Oct 02, 2006 at 12:24:47PM +0200, Jarek Poplawski wrote: > > On 30-09-2006 21:23, Ismail Donmez wrote: > > > Hi, > > > > > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > > > changed behaviour so it returns false

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Mon, Oct 02, 2006 at 04:49:38PM +0300, Ismail Donmez wrote: > 02 Eki 2006 Pts 13:24 tarihinde, Jarek Poplawski şunlar?? yazm??şt??: > > On 30-09-2006 21:23, Ismail Donmez wrote: > > > Hi, > > > > > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > > > changed behavio

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

02 Eki 2006 Pts 13:24 tarihinde, Jarek Poplawski şunları yazmıştı: > On 30-09-2006 21:23, Ismail Donmez wrote: > > Hi, > > > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > > changed behaviour so it returns false when the node is empty as expected. > > ... > > > - i

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Mon, Oct 02, 2006 at 01:15:55PM +0200, Jarek Poplawski wrote: ... > instead of: > > + if (RB_EMPTY_NODE(rb)) should be: + if (RB_EMPTY_NODE(node)) Jarek P. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Mon, Oct 02, 2006 at 12:24:47PM +0200, Jarek Poplawski wrote: > On 30-09-2006 21:23, Ismail Donmez wrote: > > Hi, > > > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > > changed behaviour so it returns false when the node is empty as expected. > ... > > - if (!

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On 30-09-2006 21:23, Ismail Donmez wrote: > Hi, > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > changed behaviour so it returns false when the node is empty as expected. ... > - if (!RB_EMPTY_NODE(rb)) { > + if (RB_EMPTY_NODE(rb)) { Maybe you have some ki

[PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

This time with correct description too, *sigh* With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns true when the node is empty as expected. Hence Patrick McHardy's fix for sched_htb.c should be reverted. [1] http://www.kernel.org/git/?p=lin

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Sunday 01 October 2006 04:52, Herbert Xu wrote: > On Sat, Sep 30, 2006 at 10:23:46PM +0300, Ismail Donmez wrote: > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > > changed behaviour so it returns false when the node is empty as expected. > > Hence Herbert's fix for

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Sat, Sep 30, 2006 at 10:23:46PM +0300, Ismail Donmez wrote: > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > changed behaviour so it returns false when the node is empty as expected. > Hence Herbert's fix for sched_htb.c should be reverted. I've fixed sched_htb

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

On Saturday 30 September 2006 22:23, you wrote: > Hi, > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > changed behaviour so it returns false when the node is empty as expected. ^ make it : so it return

[PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

Hi, With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns false when the node is empty as expected. Hence Herbert's fix for sched_htb.c should be reverted. [1] http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;