Re: [PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread Kris Katterjohn
From: David S. Miller > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Wed, 28 Dec 2005 13:38:02 -0800 > > > Unless you mean sk_filter could get set to NULL after the test, but > > before it's used. > > That's exactly what I mean. Okey-dokey then. - To unsubscribe from this list: send the

Re: [PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Wed, 28 Dec 2005 13:38:02 -0800 > Unless you mean sk_filter could get set to NULL after the test, but > before it's used. That's exactly what I mean. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [

Re: Re: [PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread Kris Katterjohn
From: David S. Miller > > Removes needless "filter" variables. > > > > Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> > > I think we need to use a local variable here, since sk->sk_filter can > be set to NULL asynchronously to the tests. That makes sense, but the local filter variables are a

Re: [PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Wed, 28 Dec 2005 13:16:55 -0800 > Removes needless "filter" variables. > > Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> I think we need to use a local variable here, since sk->sk_filter can be set to NULL asynchronously to the tests. - To u

[PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread Kris Katterjohn
Removes needless "filter" variables. Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> --- This is a diff from 2.6.15-rc7 and I'm not subscribed so please CC me on any replies. Thanks! --- x/net/core/sock.c 2005-12-28 15:10:33.0 -0600 +++ y/net/core/sock.c 2005-12-28 15:10:44.