On Thu, Jul 19, 2007 at 04:53:31AM +, Steven J. Hill wrote:
> Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.
As Christoph said, this quantity of ifdefs really hurt the
maintainability. Refactoring is needed. Also, since in arch/powerpc
we want to have a single kernel support bot
On Wed, Jul 18, 2007 at 11:53:31PM -0500, Steven J. Hill wrote:
> Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.
This is a little too much ifdef mess. Please factor per-controller type
code into helper functions, and if they're too much have separate files
for either type.
-
To unsub
Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.
Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]>
---
--- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 22:19:31.0 -0500
+++ linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c 2007-07-18 22:22:04.0 -0500
@@ -13,8 +13,7 @@