On Thu, Jul 19, 2007 at 04:53:31AM +0000, Steven J. Hill wrote: > Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.
As Christoph said, this quantity of ifdefs really hurt the maintainability. Refactoring is needed. Also, since in arch/powerpc we want to have a single kernel support both MV64[34]60 and GT64260 (determined at runtime) and their register sets are so different, I think the best approach is to have a separate module for the GT64260. Also, please follow Documentation/SubmittingPatches. Good subjects, diffstats and "diff -p" would have been helpful in reviewing this series. -Dale - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
