Re: [PATCH] Change memcmp(,,ETH_ALEN) to compare_ether_addr()

2006-01-09 Thread Pete Zaitcev
On Mon, 9 Jan 2006 11:48:49 -0800, "Kris Katterjohn" <[EMAIL PROTECTED]> wrote: > This is a diff from 2.6.15. It compiles fine and seems to work fine. > - else if (memcmp(eth->h_dest, dev->dev_addr, ETH_ALEN)) > + else if (compare_ether_addr(eth->h_dest, dev->dev_addr)) Please never mind

Re: [PATCH] Change memcmp(,,ETH_ALEN) to compare_ether_addr()

2006-01-09 Thread Pete Zaitcev
On Mon, 9 Jan 2006 11:48:49 -0800, "Kris Katterjohn" <[EMAIL PROTECTED]> wrote: > - if (memcmp(eth->h_dest, dev->broadcast, ETH_ALEN) == 0) > + if (!compare_ether_addr(eth->h_dest, dev->broadcast)) Wait a second. compare_ether_addr returns a boolean, not an error code.

Re: [PATCH] Change memcmp(,,ETH_ALEN) to compare_ether_addr()

2006-01-09 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Mon, 9 Jan 2006 15:35:05 -0800 > Okey-dokey. It patched fine on git5 for me. Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [PATCH] Change memcmp(,,ETH_ALEN) to compare_ether_addr()

2006-01-09 Thread Kris Katterjohn
From: David S. Miller Sent: 1/9/2006 3:02:35 PM > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Mon, 9 Jan 2006 11:48:49 -0800 > > > This changes some memcmp(one,two,ETH_ALEN) to compare_ether_addr(one,two). > > > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> > > Patch doesn't appl

Re: [PATCH] Change memcmp(,,ETH_ALEN) to compare_ether_addr()

2006-01-09 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Mon, 9 Jan 2006 11:48:49 -0800 > This changes some memcmp(one,two,ETH_ALEN) to compare_ether_addr(one,two). > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Patch doesn't apply, in fact due to a patch you merged to me the other day :-) > -

[PATCH] Change memcmp(,,ETH_ALEN) to compare_ether_addr()

2006-01-09 Thread Kris Katterjohn
This changes some memcmp(one,two,ETH_ALEN) to compare_ether_addr(one,two). Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15. It compiles fine and seems to work fine. Thanks! --- x/net/8021q/vlan_dev.c 2006-01-02 21:21:10.0 -0600 +++ y/net/8021q/vlan_dev