On Mon, 9 Jan 2006 11:48:49 -0800, "Kris Katterjohn" <[EMAIL PROTECTED]> wrote:

> -             if (memcmp(eth->h_dest, dev->broadcast, ETH_ALEN) == 0)
> +             if (!compare_ether_addr(eth->h_dest, dev->broadcast))

Wait a second. compare_ether_addr returns a boolean, not an error code.

        return ((a[0] ^ b[0]) | (a[1] ^ b[1]) | (a[2] ^ b[2])) != 0;

This evaluates to zero if all bytes are equal, and then some wise guy
converted it to boolean with !=, which yields 1 when they are all equal.
The return type, however, is unsigned!

Cheesus, people.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to