Re: [PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

2007-04-11 Thread Lennert Buytenhek
On Wed, Apr 11, 2007 at 04:36:49PM -0500, Kim Phillips wrote: > > On Tue, Apr 10, 2007 at 04:57:23PM -0500, Kim Phillips wrote: > > > > > also adds RX & TX delay bits to help boards with clock skew > > > problems. > > > > > > > > [...] > > > + > > > + temp |= (MII_M_RX_DELAY | MII_

Re: [PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

2007-04-11 Thread Kim Phillips
On Wed, 11 Apr 2007 03:01:58 +0200 Lennert Buytenhek <[EMAIL PROTECTED]> wrote: > On Tue, Apr 10, 2007 at 04:57:23PM -0500, Kim Phillips wrote: > > > also adds RX & TX delay bits to help boards with clock skew > > problems. > > > > [...] > > + > > + temp |= (MII_M_RX_DELAY | MII_

Re: [PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

2007-04-10 Thread Lennert Buytenhek
On Tue, Apr 10, 2007 at 04:57:23PM -0500, Kim Phillips wrote: > also adds RX & TX delay bits to help boards with clock skew problems. This doesn't make sense at all. RGMII specifies that clock and data are generated simultaneously. The necessary 1.5-2ns of clock delay is either achieved by rout

[PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

2007-04-10 Thread Kim Phillips
also adds RX & TX delay bits to help boards with clock skew problems. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.6.22 drivers/net/phy/marvell.c | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/drive