On Wed, Apr 11, 2007 at 04:36:49PM -0500, Kim Phillips wrote:

> > On Tue, Apr 10, 2007 at 04:57:23PM -0500, Kim Phillips wrote:
> > 
> > > also adds RX & TX delay bits to help boards with clock skew
> > > problems.
> > 
> <snip>
> > 
> > > [...]
> > > +
> > > +         temp |= (MII_M1111_RX_DELAY | MII_M1111_TX_DELAY);
> > 
> > Enabling this unconditionally is just wrong.
> 
> I agree.  There needs to be a way for the platform code to
> communicate board specific quirkiness to the phylib

(I'm not sure whether it's really a quirk, as the RGMII spec allows
both modes.)


> (I just haven't figured out how to yet).

Maybe offer separate RGMII and RGMII-ID[*] mode choices?


[*] RGMII with Internal Delay (RGMII specification nomenclature)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to