RE: [PATCH][v2] net: phy: add driver for aquantia phy

2015-07-30 Thread Shaohui Xie
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, July 31, 2015 6:55 AM > To: shh@gmail.com > Cc: netdev@vger.kernel.org; f.faine...@gmail.com; Xie Shaohui-B21989 > Subject: Re: [PATCH][v2] net: phy: add driver for aquantia phy

Re: [PATCH][v2] net: phy: add driver for aquantia phy

2015-07-30 Thread David Miller
From: Date: Thu, 30 Jul 2015 12:17:15 +0800 > +static int aquantia_soft_reset(struct phy_device *phydev) > +{ > + return 0; > +} > + > +static int aquantia_config_init(struct phy_device *phydev) > +{ > + return 0; > +} You shouldn't need to implement these methods at all, just leave them

[PATCH][v2] net: phy: add driver for aquantia phy

2015-07-29 Thread shh.xie
From: Shaohui Xie This patch added driver to support Aquantia PHYs AQ1202, AQ2104, AQR105, AQR405, which accessed through clause 45. Signed-off-by: Shaohui Xie --- changes in v2: addressed Florian's comments. drivers/net/phy/Kconfig| 5 ++ drivers/net/phy/Makefile | 1 + drivers/net