> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, July 31, 2015 6:55 AM > To: shh....@gmail.com > Cc: netdev@vger.kernel.org; f.faine...@gmail.com; Xie Shaohui-B21989 > Subject: Re: [PATCH][v2] net: phy: add driver for aquantia phy > > From: <shh....@gmail.com> > Date: Thu, 30 Jul 2015 12:17:15 +0800 > > > +static int aquantia_soft_reset(struct phy_device *phydev) { > > + return 0; > > +} > > + > > +static int aquantia_config_init(struct phy_device *phydev) { > > + return 0; > > +} > > You shouldn't need to implement these methods at all, just leave them > NULL in the driver struct. > > The only thing implementing them as nop routines like this does is make > the PHY fixups get scanned. And I don't think there are any for this > device. [S.H] OK. Will remove the nop routines in next version. Thanks!
Shaohui -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
