Re: [IPCOMP]: Fix truesize after decompression

2006-07-11 Thread Herbert Xu
On Tue, Jul 11, 2006 at 04:22:17PM -0700, David Miller wrote: > > What ATM is doing here is charging the SKB to the virtual circuit > sockets. At least in the few cases I've looked at just now, the > skb is some private ATM level signalling message, and not part of > a normal transmit/receive pac

Re: [IPCOMP]: Fix truesize after decompression

2006-07-11 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 12 Jul 2006 09:12:51 +1000 > On Tue, Jul 11, 2006 at 01:55:53PM -0700, David Miller wrote: > > > > I think it is possible cover a certain class of these situations > > from within pskb_expand_head. For example, if skb->sk is NULL > > we can prove t

Re: [IPCOMP]: Fix truesize after decompression

2006-07-11 Thread Herbert Xu
On Tue, Jul 11, 2006 at 01:55:53PM -0700, David Miller wrote: > > I think it is possible cover a certain class of these situations > from within pskb_expand_head. For example, if skb->sk is NULL > we can prove that updating skb->truesize is safe since no > socket's buffer accounting can possible

Re: [IPCOMP]: Fix truesize after decompression

2006-07-11 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 11 Jul 2006 21:45:44 +1000 > [IPCOMP]: Fix truesize after decompression > > The truesize check has uncovered the fact that we forgot to update truesize > after pskb_expand_head. Unfortunately pskb_expand_head can't update i

[IPCOMP]: Fix truesize after decompression

2006-07-11 Thread Herbert Xu
ate truesizes is not easy due to the large numbers of pskb_expand_head calls scattered around the stack. [IPCOMP]: Fix truesize after decompression The truesize check has uncovered the fact that we forgot to update truesize after pskb_expand_head. Unfortunately pskb_expand_head can't update it