From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 12 Jul 2006 09:12:51 +1000
> On Tue, Jul 11, 2006 at 01:55:53PM -0700, David Miller wrote: > > > > I think it is possible cover a certain class of these situations > > from within pskb_expand_head. For example, if skb->sk is NULL > > we can prove that updating skb->truesize is safe since no > > socket's buffer accounting can possible depend upon the truesize > > value of this skb. > > Yes that's certainly possible. However, we'll need to audit the few > spots (e.g., ATM) that use truesize without setting skb->sk. Yuck, I'd forgotten about that usage.... What ATM is doing here is charging the SKB to the virtual circuit sockets. At least in the few cases I've looked at just now, the skb is some private ATM level signalling message, and not part of a normal transmit/receive packet from the normal networking stack. Therefore, there seems to be no reason why ATM can't use the destructor callback of the SKB to manage this accounting just like the rest of the kernel does. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
