RE: [EXT] Re: [PATCH v2 RFC net-next 04/18] net: mvpp2: add PPv23 version definition

2021-01-24 Thread Stefan Chulski
> > We cannot access PPv2 register space before enabling clocks(done in > mvpp2_probe) , PP21 and PP22/23 have different sets of clocks. > > > So diff between PP21 and PP22/23 should be stored in device tree(in > > of_device_id), with MVPP22 and MVPP21 stored as .data > > Hi Stefan > > As far as

Re: [EXT] Re: [PATCH v2 RFC net-next 04/18] net: mvpp2: add PPv23 version definition

2021-01-24 Thread Andrew Lunn
On Sun, Jan 24, 2021 at 01:55:42PM +, Stefan Chulski wrote: > > > Signed-off-by: Stefan Chulski > > > --- > > > drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 -- > > -- > > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 17 +- > > > 2 files changed, 25

RE: [EXT] Re: [PATCH v2 RFC net-next 04/18] net: mvpp2: add PPv23 version definition

2021-01-24 Thread Stefan Chulski
> > Signed-off-by: Stefan Chulski > > --- > > drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 -- > -- > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 17 +- > > 2 files changed, 25 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/net/ethernet/mar