答复: [PATCH] ipv6: Fix error path to cancel the meseage

2020-11-13 Thread zhangqilong
> > On Thu, 12 Nov 2020 16:09:50 +0800 Zhang Qilong wrote: > > genlmsg_cancel() needs to be called in the error path of > > inet6_fill_ifmcaddr and inet6_fill_ifacaddr to cancel the message. > > > > Fixes: 203651b665f72 ("ipv6: add inet6_fill_args") > > Reported-by: Hulk Robot > > Signed-off-by:

答复: [PATCH v2 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread zhangqilong
Hi > > On Mon, Nov 9, 2020 at 4:50 PM zhangqilong > wrote: > > > > > operation to deal with usage counter > > > > > > On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong > > > > > > wrote: > > > > > > > > In many

答复: [PATCH v2 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread zhangqilong
> operation to deal with usage counter > > On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong > wrote: > > > > In many case, we need to check return value of pm_runtime_get_sync, > > but it brings a trouble to the usage counter processing. Many callers > > forget to decrease the usage counter when it fa

答复: [PATCH 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread zhangqilong
> On Mon, Nov 9, 2020 at 2:46 PM zhangqilong > wrote: > > > > Hi, > > > > > > > > On Mon, Nov 9, 2020 at 2:24 PM zhangqilong > > > wrote: > > > > > > > > Hi > > > > > > > > > > On Mon, Nov

答复: [PATCH 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread zhangqilong
Hi, > > On Mon, Nov 9, 2020 at 2:24 PM zhangqilong > wrote: > > > > Hi > > > > > > On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong > > > > > > wrote: > > > > > > > > In many case, we need to check return v

答复: [PATCH 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread zhangqilong
Hi > > On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong > wrote: > > > > In many case, we need to check return value of pm_runtime_get_sync, > > but it brings a trouble to the usage counter processing. Many callers > > forget to decrease the usage counter when it failed. It has been > > discussed a lo

答复: [PATCH] net: fec: Fix reference count leak in fec series ops

2020-11-09 Thread zhangqilong
> From: zhangqilong ent: Monday, November 9, > 2020 10:52 AM > > > From: Zhang Qilong Sent: Sunday, November > > > 8, > > > 2020 5:53 PM > > > > pm_runtime_get_sync() will increment pm usage at first and it will > > > > resume the device la

答复: [PATCH] net: fec: Fix reference count leak in fec series ops

2020-11-08 Thread zhangqilong
> From: Zhang Qilong Sent: Sunday, November 8, > 2020 5:53 PM > > pm_runtime_get_sync() will increment pm usage at first and it will > > resume the device later. If runtime of the device has error or device > > is in inaccessible state(or other error state), resume operation will > > fail. If we d

答复: [PATCH -next] neigh: remove the extra slash

2020-10-25 Thread zhangqilong
> On Fri, 2020-10-23 at 13:16 +0300, Vasily Averin wrote: > > On 10/23/20 1:01 PM, Zhang Qilong wrote: > > > The normal path has only one slash. > > > > it is not normal path > > this string is used to calculate number of symbols in > > "net/%s/neigh/%s" used below > > Then probably better would b