Re: [bug report] net: hns3: vf indexing in hclge_add_fd_entry()

2021-03-24 Thread shenjian (K)
Hello Dan, Thanks for your  report! 在 2021/3/24 15:01, Dan Carpenter 写道: Hello Jian Shen, The patch 5f2b1238b33c: "net: hns3: refactor out hclge_add_fd_entry()" from Mar 22, 2021, leads to the following static checker warning: drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:6

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread shenjian (K)
在 2019/8/28 3:41, Heiner Kallweit 写道: > On 27.08.2019 10:29, shenjian (K) wrote: >> >> >> 在 2019/8/27 13:51, Heiner Kallweit 写道: >>> On 27.08.2019 04:47, Jian Shen wrote: >>>> Some ethernet drivers may call phy_start() and phy_stop() from

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread shenjian (K)
在 2019/8/27 18:11, Sergei Shtylyov 写道: > On 27.08.2019 5:47, Jian Shen wrote: > >> Some ethernet drivers may call phy_start() and phy_stop() from >> ndo_open and ndo_close() respectively. > >    ndo_open() for consistency. > >> When network cable is unconnected, and operate like below: >> ste

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread shenjian (K)
在 2019/8/27 13:51, Heiner Kallweit 写道: > On 27.08.2019 04:47, Jian Shen wrote: >> Some ethernet drivers may call phy_start() and phy_stop() from >> ndo_open and ndo_close() respectively. >> >> When network cable is unconnected, and operate like below: >> step 1: ifconfig ethX up -> ndo_open -> p

Re: [PATCH net-next 2/2] net: hns3: add fixup handle for hns3 driver

2019-02-13 Thread shenjian (K)
在 2019/2/14 12:08, Florian Fainelli 写道: > > > On 2/13/2019 8:31 PM, Jian Shen wrote: >> The default led configuration of marvell 88E1510 is not fit >> for hns3 driver, this patch fixes it. >> >> Signed-off-by: Jian Shen >> --- >> .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 19 >>

Re: [PATCH net-next 1/2] net: phy: marvell: add new m88e1510 LED configuration

2019-02-13 Thread shenjian (K)
在 2019/2/14 12:06, Florian Fainelli 写道: > > > On 2/13/2019 8:31 PM, Jian Shen wrote: >> The default m88e1510 LED configuration is 0x1177, used LED[0] >> for 1000M link, LED[1] for 100M link, and LED[2] for active. >> But for our boards, we want to use 0x1040, which use LED[0] for >> link, and

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-17 Thread shenjian (K)
在 2019/1/17 20:41, Andrew Lunn 写道: > On Thu, Jan 17, 2019 at 10:58:07AM +0800, shenjian (K) wrote: >> >> >> 在 2019/1/17 0:04, Andrew Lunn 写道: >>>> Thanks, Andrew. >>>> >>>> But we are using acpi mode, is there any ohter way to poke val

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-16 Thread shenjian (K)
在 2019/1/15 17:08, Wang, Dongsheng 写道: > On 2019/1/15 14:41, shenjian (K) wrote: >> >> 在 2019/1/15 11:39, Andrew Lunn 写道: >>> On Tue, Jan 15, 2019 at 11:07:17AM +0800, shenjian (K) wrote: >>>> Hi, all >>>>We encounted a problem when using th

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-16 Thread shenjian (K)
在 2019/1/17 0:04, Andrew Lunn 写道: >> Thanks, Andrew. >> >> But we are using acpi mode, is there any ohter way to poke values into >> registers ? > > You can register a PHY fixup. > > phy_register_fixup_for_uid(), mach-orion5x/dns323-setup.c > > Andrew > > . > Thanks Andrew! I have t

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-14 Thread shenjian (K)
在 2019/1/15 11:39, Andrew Lunn 写道: > On Tue, Jan 15, 2019 at 11:07:17AM +0800, shenjian (K) wrote: >> Hi, all >> We encounted a problem when using the marvel 88e151x phy driver, the >> link(LED[0])/ack(LED[1]) leds worked abnormally since we updated our kernel >&g

Question about default m88e1510 LED configuration of marvell phy

2019-01-14 Thread shenjian (K)
Hi, all We encounted a problem when using the marvel 88e151x phy driver, the link(LED[0])/ack(LED[1]) leds worked abnormally since we updated our kernel to v4.19. The act led kept on and never blink. It works well when we use genphy driver, aslo works well when use marvell phy in kernel