[PATCH net-next v2 3/3] net: phy: marvell-88x2222: swap 1G/10G modes on autoneg

2021-04-13 Thread Ivan Bornyakov
nk to be established. And vice versa. If 10GBase-R link can't be established for quite a time, and autonegotiation is enabled, and there is signal in line, switch line interface type to appropriate 1G mode, i.e. 1000Base-X or SGMII, if supported. Signed-off-by: Ivan Bornyakov --- drive

[PATCH net-next v2 0/3] net: phy: marvell-88x2222: a couple of improvements

2021-04-13 Thread Ivan Bornyakov
for the sake of easier review. Ivan Bornyakov (3): net: phy: marvell-88x: check that link is operational net: phy: marvell-88x: move read_status after config_aneg net: phy: marvell-88x: swap 1G/10G modes on autoneg drivers/net/phy/marvell-88x.c | 314 -

[PATCH net-next v2 1/3] net: phy: marvell-88x2222: check that link is operational

2021-04-13 Thread Ivan Bornyakov
to the tranciever, check only PMD Recieve Signal Detect register. Signed-off-by: Ivan Bornyakov --- drivers/net/phy/marvell-88x.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/drivers/net/phy/marvell-88x.c b/drivers/net/phy/marvell-88x.c index

[PATCH net-next v2 2/3] net: phy: marvell-88x2222: move read_status after config_aneg

2021-04-13 Thread Ivan Bornyakov
No functional changes, just move read link status routines below autonegotiation configuration to make future functional changes more distinct. Signed-off-by: Ivan Bornyakov --- drivers/net/phy/marvell-88x.c | 196 +++--- 1 file changed, 98 insertions(+), 98

Re: [PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-13 Thread Ivan Bornyakov
On Tue, Apr 13, 2021 at 10:23:48AM +0100, Russell King - ARM Linux admin wrote: > On Tue, Apr 13, 2021 at 10:19:30AM +0300, Ivan Bornyakov wrote: > > On Tue, Apr 13, 2021 at 01:40:32AM +0200, Andrew Lunn wrote: > > > On Mon, Apr 12, 2021 at 03:16:59PM +0300, Ivan Bornyakov wrote

Re: [PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-13 Thread Ivan Bornyakov
On Tue, Apr 13, 2021 at 01:40:32AM +0200, Andrew Lunn wrote: > On Mon, Apr 12, 2021 at 03:16:59PM +0300, Ivan Bornyakov wrote: > > Some SFP modules uses RX_LOS for link indication. In such cases link > > will be always up, even without cable connected. RX_LOS changes will >

Re: [PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-13 Thread Ivan Bornyakov
On Tue, Apr 13, 2021 at 01:32:12AM +0200, Marek Behún wrote: > On Mon, 12 Apr 2021 15:16:59 +0300 > Ivan Bornyakov wrote: > > > Some SFP modules uses RX_LOS for link indication. In such cases link > > will be always up, even without cable connected. RX_LOS changes wil

[PATCH net-next 2/2] net: phy: marvell-88x2222: swap 1G/10G modes on autoneg

2021-04-12 Thread Ivan Bornyakov
ff-by: Ivan Bornyakov --- drivers/net/phy/marvell-88x.c | 276 ++ 1 file changed, 168 insertions(+), 108 deletions(-) diff --git a/drivers/net/phy/marvell-88x.c b/drivers/net/phy/marvell-88x.c index fb285ac741b2..d16c81f08334 100644 --- a/drivers/net/phy/ma

[PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-12 Thread Ivan Bornyakov
Some SFP modules uses RX_LOS for link indication. In such cases link will be always up, even without cable connected. RX_LOS changes will trigger link_up()/link_down() upstream operations. Thus, check that SFP link is operational before actual read link status. Signed-off-by: Ivan Bornyakov

[PATCH net-next 0/2] net: phy: marvell-88x2222: a couple of improvements

2021-04-12 Thread Ivan Bornyakov
and 1000Base-X/SGMII if autonegotiation can't complete but there is signal in line. Ivan Bornyakov (2): net: phy: marvell-88x: check that link is operational net: phy: marvell-88x: swap 1G/10G modes on autoneg drivers/net/phy/marvell-88x.c | 296 +++-

[PATCH net] net: octeon: mgmt: fix xmit hang as busy

2021-04-02 Thread Ivan Khoronzhuk
2958489503fc0ab Signed-off-by: Ivan Khoronzhuk --- Based on net/master drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c index ecffebd513be..be1c

[RESEND PATCH v4 net-next] net: phy: add Marvell 88X2222 transceiver support

2021-03-15 Thread Ivan Bornyakov
. Signed-off-by: Ivan Bornyakov --- drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile | 1 + drivers/net/phy/marvell-88x.c | 519 ++ include/linux/marvell_phy.h | 1 + 4 files changed, 527 insertions(+) create mode 100644 drivers

Re: [PATCH v4] net: phy: add Marvell 88X2222 transceiver support

2021-03-10 Thread Ivan Bornyakov
On Wed, Mar 03, 2021 at 07:02:11PM +0300, Ivan Bornyakov wrote: > Add basic support for the Marvell 88X multi-speed ethernet > transceiver. > > This PHY provides data transmission over fiber-optic as well as Twinax > copper links. The 88X supports 2 ports of 10GBase-R and

[PATCH v4] net: phy: add Marvell 88X2222 transceiver support

2021-03-03 Thread Ivan Bornyakov
. Signed-off-by: Ivan Bornyakov --- drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile | 1 + drivers/net/phy/marvell-88x.c | 519 ++ include/linux/marvell_phy.h | 1 + 4 files changed, 527 insertions(+) create mode 100644 drivers

Re: [PATCH v3] net: phy: add Marvell 88X2222 transceiver support

2021-03-03 Thread Ivan Bornyakov
On Wed, Mar 03, 2021 at 11:36:55AM +, Russell King - ARM Linux admin wrote: > > > + linkmode_set_bit(ETHTOOL_LINK_MODE_1baseKR_Full_BIT, supported); > > Does the PHY support backplane links? > It looks like it does, but our hardware only have SFP cages, so I'll drop backplane link mod

[PATCH v3] net: phy: add Marvell 88X2222 transceiver support

2021-03-03 Thread Ivan Bornyakov
. Signed-off-by: Ivan Bornyakov --- drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile | 1 + drivers/net/phy/marvell-88x.c | 533 ++ include/linux/marvell_phy.h | 1 + 4 files changed, 541 insertions(+) create mode 100644 drivers

Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Ivan Bornyakov
On Sat, Feb 20, 2021 at 11:53:04AM +, Russell King - ARM Linux admin wrote: > On Sat, Feb 20, 2021 at 12:46:23PM +0300, Ivan Bornyakov wrote: > > + > > + switch (sfp_interface) { > > + case PHY_INTERFACE_MODE_10GBASER: > > +

[PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Ivan Bornyakov
. Signed-off-by: Ivan Bornyakov --- drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile | 1 + drivers/net/phy/marvell-88x.c | 510 ++ include/linux/marvell_phy.h | 1 + 4 files changed, 518 insertions(+) create mode 100644 drivers

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 4:17 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 03:30:35PM -0800, Ivan Babrou wrote: > > > > > Can you recreate with this patch, and add "unwind_debug" to the > > > > > cmdline? > > > > > It will spi

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 7:10 PM Josh Poimboeuf wrote: > This line gives a big clue: > > [160676.608966][C4] RIP: 0010:0xc17d814c > > That address, without a function name, most likely means that it was > running in some generated code (mostly likely BPF) when it got > interrupted. W

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 4:17 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 03:30:35PM -0800, Ivan Babrou wrote: > > > > > Can you recreate with this patch, and add "unwind_debug" to the > > > > > cmdline? > > > > > It will spi

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 3:28 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 02:41:53PM -0800, Ivan Babrou wrote: > > On Wed, Feb 3, 2021 at 11:05 AM Josh Poimboeuf wrote: > > > > > > On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > >

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 11:05 AM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > > Can you pretty please not line-wrap console output? It's unreadable. > > > > GMail doesn't make it easy, I'll send a link to a pa

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
> Can you pretty please not line-wrap console output? It's unreadable. GMail doesn't make it easy, I'll send a link to a pastebin next time. Let me know if you'd like me to regenerate the decoded stack. > > edfd9b7838ba5e47f19ad8466d0565aba5c59bf0 is the first bad commit > > commit edfd9b7838ba5e

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-02 Thread Ivan Babrou
On Thu, Jan 28, 2021 at 7:35 PM Ivan Babrou wrote: > > Hello, > > We've noticed the following regression in Linux 5.10 branch: > > [ 128.367231][C0] > == > [ 128.368523][C0] BUG:

Re: [PATCH] net: phy: add Marvell 88X2222 transceiver support

2021-02-02 Thread Ivan Bornyakov
On Tue, Feb 02, 2021 at 04:48:01PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 01, 2021 at 10:22:51PM +0300, Ivan Bornyakov wrote: > > +/* PMD Transmit Disable */ > > +#defineMV_TX_DISABLE 0x0009 > > +#defineMV_TX_DISABLE_GLOBALB

Re: [PATCH] net: phy: add Marvell 88X2222 transceiver support

2021-02-02 Thread Ivan Bornyakov
On Mon, Feb 01, 2021 at 11:56:01PM +0100, Andrew Lunn wrote: > > +static int mv_config_init(struct phy_device *phydev) > > +{ > > + linkmode_zero(phydev->supported); > > + linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->supported); > > + linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BI

[PATCH] net: phy: add Marvell 88X2222 transceiver support

2021-02-01 Thread Ivan Bornyakov
-R, RXAUI, 1000Base-X and 2 ports of XAUI. This driver, however, supports only XAUI on the host-side and 1000Base-X/10GBase-R on the line-side, for now. Interrupts are not supported also. Internal registers access compliant with the Clause 45 specification. Signed-off-by: Ivan Bornyakov

Re: [PATCH net] team: protect features update by RCU to avoid deadlock

2021-01-26 Thread Ivan Vecera
On Mon, 25 Jan 2021 12:53:22 -0800 Cong Wang wrote: > On Sun, Jan 24, 2021 at 11:44 PM Ivan Vecera wrote: > > > > Function __team_compute_features() is protected by team->lock > > mutex when it is called from team_compute_features() used when > > features of a

[PATCH net] team: protect features update by RCU to avoid deadlock

2021-01-24 Thread Ivan Vecera
: 3d249d4ca7d0 ("net: introduce ethernet teaming device") Cc: Jiri Pirko Cc: David S. Miller Cc: Cong Wang Cc: Jakub Kicinski Cc: Saeed Mahameed Signed-off-by: Ivan Vecera --- drivers/net/team/team.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/n

Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-22 Thread Ivan Vecera
On Thu, 21 Jan 2021 18:34:52 -0800 Jakub Kicinski wrote: > On Thu, 21 Jan 2021 11:29:37 +0100 Ivan Vecera wrote: > > On Wed, 20 Jan 2021 15:18:20 -0800 > > Cong Wang wrote: > > > On Wed, Jan 20, 2021 at 4:56 AM Ivan Vecera wrote: > > > > > > >

Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-21 Thread Ivan Vecera
On Wed, 20 Jan 2021 15:18:20 -0800 Cong Wang wrote: > On Wed, Jan 20, 2021 at 4:56 AM Ivan Vecera wrote: > > > > To fix the problem __team_compute_features() needs to be postponed > > for these cases. > > Is there any user-visible effect after deferring this featur

[PATCH net-next] sfc: reduce the number of requested xdp ev queues

2021-01-20 Thread Ivan Babrou
processing: sfc :86:00.0 ext0: XDP TX failed (-22) Signed-off-by: Ivan Babrou --- drivers/net/ethernet/sfc/efx_channels.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index

Re: [PATCH net] team: fix deadlock during setting of MTU

2021-01-20 Thread Ivan Vecera
On Fri, 15 Jan 2021 09:24:05 +0100 Ivan Vecera wrote: > > according to your explanation in the commit message the team->lock > > mutex will be also taken under this rcu lock, so this is bad even > > if dev_set_mtu does not sleep. > > > Hmm, you are right... btw

[PATCH net] team: postpone features update to avoid deadlock

2021-01-20 Thread Ivan Vecera
net teaming device") Cc: Jiri Pirko Signed-off-by: Ivan Vecera --- drivers/net/team/team.c | 36 +++- include/linux/if_team.h | 1 + 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index c19dac21c4

Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2021-01-19 Thread Ivan Babrou
On Thu, Dec 17, 2020 at 10:14 AM Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 17:29:06 -0800 Ivan Babrou wrote: > > Without this change the driver tries to allocate too many queues, > > breaching the number of available msi-x interrupts on machines > > with many logical

Re: [PATCH net] team: fix deadlock during setting of MTU

2021-01-15 Thread Ivan Vecera
On Thu, 14 Jan 2021 16:34:24 -0800 Saeed Mahameed wrote: > On Thu, 2021-01-14 at 12:55 +0100, Ivan Vecera wrote: > > Team driver protects port list traversal in team_change_mtu() > > by its team->lock mutex. This causes a deadlock with certain > > devices that call

[PATCH net] team: fix deadlock during setting of MTU

2021-01-14 Thread Ivan Vecera
e port list traversal in team_change_mtu() can be protected by RCU read lock. In case of failure the failing port is marked and unwind code-path is done also under RCU read lock protection (but not in reverse order). Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device") Cc: Jiri Pirko

[PATCH net] ethtool: fix error paths in ethnl_set_channels()

2020-12-15 Thread Ivan Vecera
Fix two error paths in ethnl_set_channels() to avoid lock-up caused but unreleased RTNL. Fixes: e19c591eafad ("ethtool: set device channel counts with CHANNELS_SET request") Cc: Michal Kubecek Reported-by: LiLiang Signed-off-by: Ivan Vecera --- net/ethtool/channels.c | 6

[PATCH net-next] sfc: reduce the number of requested xdp ev queues

2020-12-14 Thread Ivan Babrou
processing: sfc :86:00.0 ext0: XDP TX failed (-22) Signed-off-by: Ivan Babrou --- drivers/net/ethernet/sfc/efx_channels.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index

Re: [PATCH net-next] sfc: backport XDP EV queue sharing from the out-of-tree driver

2020-12-13 Thread Ivan Babrou
On Sun, Dec 13, 2020 at 4:23 AM Martin Habets wrote: > > On Thu, Dec 10, 2020 at 04:18:53PM -0800, Ivan Babrou wrote: > > Queue sharing behaviour already exists in the out-of-tree sfc driver, > > available under xdp_alloc_tx_resources module parameter. > > This comment is

[PATCH net-next] sfc: backport XDP EV queue sharing from the out-of-tree driver

2020-12-10 Thread Ivan Babrou
XDP processing: sfc :86:00.0 ext0: XDP TX failed (-22) Signed-off-by: Ivan Babrou --- drivers/net/ethernet/sfc/efx_channels.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index

[PATCH 2/2] dt-bindings: net: phy: micrel: add LED mode behavior and select properties

2020-12-09 Thread Ivan Mikhaylov
Add LED mode behavior and LED mode select properties which can be used in KSZ9131 PHY. Signed-off-by: Ivan Mikhaylov --- Documentation/devicetree/bindings/net/micrel.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/micrel.txt b/Documentation

[PATCH 1/2] net: phy: micrel: add LED control on KSZ9131

2020-12-09 Thread Ivan Mikhaylov
Add the possibility to read the LED configuration via DTS properties from KSZ9131 PHY node. Add the new proprties and handle for them: micrel,led-mode-behavior micrel,led-mode-select Signed-off-by: Ivan Mikhaylov --- drivers/net/phy/micrel.c | 69 +++- 1 file

[PATCH 0/2] Add LED mode behavior/select properties and handle

2020-12-09 Thread Ivan Mikhaylov
e properly? Ivan Mikhaylov (2): net: phy: micrel: add LED control on KSZ9131 dt-bindings: net: phy: micrel: add LED mode behavior and select properties .../devicetree/bindings/net/micrel.txt| 7 ++ drivers/net/phy/micrel.c | 69 ++- 2 files c

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Ivan Vecera
work based on further testing and suggestions from ivecera > > Fixes: a3b658cfb664 ("bonding: allow xfrm offload setup post-module-load") > Reported-by: Ivan Vecera > Suggested-by: Ivan Vecera > Cc: Jay Vosburgh > Cc: Veaceslav Falico > Cc: Andy Gospodarek >

Re: [PATCH net-next 7/9] bridge: switchdev: Notify about VLAN protocol changes

2020-11-30 Thread Ivan Vecera
dr(br); > @@ -889,6 +898,9 @@ int __br_vlan_set_proto(struct net_bridge *br, __be16 > proto) > return 0; > > err_filt: > + attr.u.vlan_protocol = ntohs(oldproto); > + switchdev_port_attr_set(br->dev, &attr); > + > list_for_each_entry_continue_reverse(vlan, &vg->vlan_list, vlist) > vlan_vid_del(p->dev, proto, vlan->vid); > Reviewed-by: Ivan Vecera

Re: [PATCH net] bonding: fix feature flag setting at init time

2020-11-23 Thread Ivan Vecera
BOND_MODE_ACTIVEBACKUP) + bond->dev->wanted_features |= BOND_XFRM_FEATURES; + else + bond->dev->wanted_features &= ~BOND_XFRM_FEATURES; + netdev_change_features(bond->dev); + } #endif /* CONFIG_XFRM_OFFLOAD */ Thanks, Ivan

[PATCH v3 3/3] dt-bindings: net: ftgmac100: describe phy-handle and MDIO

2020-10-30 Thread Ivan Mikhaylov
Add the phy-handle and MDIO description and add the example with PHY and MDIO nodes. Signed-off-by: Ivan Mikhaylov --- .../devicetree/bindings/net/ftgmac100.txt | 25 +++ 1 file changed, 25 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b

[PATCH v3 2/3] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-30 Thread Ivan Mikhaylov
phy-handle can't be handled well for ast2400/2500 which has an embedded MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize PHYs from mdio child node with of_mdiobus_register. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c

[PATCH v3 1/3] net: ftgmac100: move phy connect out from ftgmac100_setup_mdio

2020-10-30 Thread Ivan Mikhaylov
Split MDIO registration and PHY connect into ftgmac100_setup_mdio and ftgmac100_mii_probe. Reviewed-by: Andrew Lunn Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c | 104 --- 1 file changed, 54 insertions(+), 50 deletions(-) diff --git a/drivers

[PATCH v3 0/3] add ast2400/2500 phy-handle support

2020-10-30 Thread Ivan Mikhaylov
t label. 3. split ftgmac100_destroy_mdio into ftgmac100_phy_disconnect and ftgmac100_destroy_mdio. 4. remove unneeded mdio_np checks. Changes from v1: 1. split one patch into two. Ivan Mikhaylov (3): net: ftgmac100: move phy connect out from ftgmac100_setup_mdio net: ftgmac100: add handling of md

Re: [PATCH v2 2/2] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-28 Thread Ivan Mikhaylov
On Tue, 2020-10-27 at 19:23 +0100, Andrew Lunn wrote: > On Tue, Oct 27, 2020 at 05:49:24PM +0300, Ivan Mikhaylov wrote: > > phy-handle can't be handled well for ast2400/2500 which has an embedded > > MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize >

[PATCH v2 0/2] add ast2400/2500 phy-handle support

2020-10-27 Thread Ivan Mikhaylov
unneeded mdio_np checks. Changes from v1: 1. split one patch into two. Ivan Mikhaylov (2): net: ftgmac100: move phy connect out from ftgmac100_setup_mdio net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500 drivers/net/ethernet/faraday/ftgmac100.c | 122 +--

[PATCH v2 1/2] net: ftgmac100: move phy connect out from ftgmac100_setup_mdio

2020-10-27 Thread Ivan Mikhaylov
Split MDIO registration and PHY connect into ftgmac100_setup_mdio and ftgmac100_mii_probe. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c | 104 --- 1 file changed, 54 insertions(+), 50 deletions(-) diff --git a/drivers/net/ethernet/faraday

[PATCH v2 2/2] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-27 Thread Ivan Mikhaylov
phy-handle can't be handled well for ast2400/2500 which has an embedded MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize PHYs from mdio child node with of_mdiobus_register. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c

[PATCH v1 2/2] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-15 Thread Ivan Mikhaylov
phy-handle can't be handled well for ast2400/2500 which has an embedded MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize PHYs from mdio child node with of_mdiobus_register. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c

[PATCH v1 1/2] net: ftgmac100: move phy connect out from ftgmac100_setup_mdio

2020-10-15 Thread Ivan Mikhaylov
Split MDIO registration and PHY connect into ftgmac100_setup_mdio and ftgmac100_mii_probe. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c | 92 1 file changed, 47 insertions(+), 45 deletions(-) diff --git a/drivers/net/ethernet/faraday

[PATCH v1 0/2] add ast2400/2500 phy-handle support

2020-10-15 Thread Ivan Mikhaylov
#address-cells = <1>; #size-cells = <0>; phy: ethernet-phy@0 { compatible = "ethernet-phy-id."; reg = <0>; }; }; }; The patch fixes it and gets possible PHYs a

Re: [PATCH 1/1] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-14 Thread Ivan Mikhaylov
On Wed, 2020-10-14 at 05:23 +, Joel Stanley wrote: > Hi Ivan, > > On Tue, 13 Oct 2020 at 12:38, Ivan Mikhaylov wrote: > > phy-handle can't be handled well for ast2400/2500 which has an embedded > > MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and ini

[PATCH 1/1] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-13 Thread Ivan Mikhaylov
phy-handle can't be handled well for ast2400/2500 which has an embedded MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize PHYs from mdio child node with of_mdiobus_register. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c

[PATCH 0/1] add ast2400/2500 phy-handle support

2020-10-13 Thread Ivan Mikhaylov
#address-cells = <1>; #size-cells = <0>; phy: ethernet-phy@0 { compatible = "ethernet-phy-id."; reg = <0>; }; }; }; The patch fixes it and gets possible PHYs a

Re: [RESEND PATCH iproute2-next 0/2] Implement filter terse dump mode support

2020-09-30 Thread Ivan Vecera
m_skbedit.c| 2 +- > tc/m_skbmod.c | 2 +- > tc/m_tunnel_key.c | 2 +- > tc/m_vlan.c | 2 +- > tc/m_xt.c | 2 +- > tc/m_xt_old.c | 2 +- > tc/tc_filter.c | 12 > 21 files changed, 32 insertions(+), 20 deletions(-) > Tested-by: Ivan Vecera

Re: [PATCH ethtool 1/2] netlink: return -ENOMEM when calloc fails

2020-09-28 Thread Ivan Vecera
On Mon, 28 Sep 2020 17:44:55 +0200 Michal Kubecek wrote: > On Thu, Sep 24, 2020 at 09:27:57PM +0200, Ivan Vecera wrote: > > Fixes: f2c17e107900 ("netlink: add netlink handler for gfeatures (-k)") > > > > Cc: Michal Kubecek > > Signed-off-by: Ivan Vecera

[PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and phy_stop

2020-09-25 Thread Ivan Khoronzhuk
atch, so add it as a fix. Fixes: 74a992b3598a ("net: phy: add phy_check_link_status") Signed-off-by: Ivan Khoronzhuk --- Based on net/master drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ca

[PATCH ethtool 1/2] fix memory leaks in do_sfeatures()

2020-09-25 Thread Ivan Vecera
Memory blocks referenced by new_state and old_state are never freed. For efeatures there is no need to check pointer as free() can be called with NULL parameter. Fixes: 6042804cf6ec ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES") Cc: Michal Kubecek Signed-off-by: I

[PATCH ethtool 2/2] netlink: fix copy-paste error in rtm_link_summary()

2020-09-25 Thread Ivan Vecera
Fixes: bdfffab54933 ("netlink: message format descriptions for rtnetlink") Cc: Michal Kubecek Signed-off-by: Ivan Vecera --- netlink/prettymsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlink/prettymsg.c b/netlink/prettymsg.c index 9e62bebe615e..f992dcaf0

[PATCH ethtool 2/2] netlink: fix memory leak

2020-09-24 Thread Ivan Vecera
Potentially allocated memory allocated for mask is not freed when the allocation for value fails. Fixes: 81a30f416ec7 ("netlink: add bitset command line parser handlers") Cc: Michal Kubecek Signed-off-by: Ivan Vecera --- netlink/parser.c | 4 +++- 1 file changed, 3 insertions(+),

[PATCH ethtool 1/2] netlink: return -ENOMEM when calloc fails

2020-09-24 Thread Ivan Vecera
Fixes: f2c17e107900 ("netlink: add netlink handler for gfeatures (-k)") Cc: Michal Kubecek Signed-off-by: Ivan Vecera --- netlink/features.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/netlink/features.c b/netlink/features.c index 3f1240437350..b2

Re: [PATCH] net: switchdev: Fixed kerneldoc warning

2020-09-22 Thread Ivan Vecera
otifier blocks. > */ > int call_switchdev_notifiers(unsigned long val, struct net_device *dev, Acked-by: Ivan Vecera

Re: [PATCH net-next 5/8] bridge: Add SWITCHDEV_FDB_FLUSH_TO_BRIDGE notifier

2020-09-15 Thread Ivan Vecera
dgeport are not deleted. > > Note that this has the same effect as the IFLA_BRPORT_FLUSH attribute. > > CC: Jiri Pirko > CC: Ivan Vecera > CC: Roopa Prabhu > CC: Nikolay Aleksandrov > Signed-off-by: Alexandra Winter > Signed-off-by: Julian Wiedmann > --- >

[PATCH] wireless: rtw88: rtw8822c: eliminate code duplication, use native swap() function

2020-09-13 Thread Ivan Safonov
swap_u32() duplicate native swap(), so replace swap_u32() with swap(). Signed-off-by: Ivan Safonov --- drivers/net/wireless/realtek/rtw88/rtw8822c.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net

Re: [PATCH net] net/sched: fix infinite loop in sch_fq_pie

2020-05-27 Thread Ivan Vecera
will never end. The extack message is correct, but > it doesn't say that 0 is not a valid number for 'flows': while at it, fix > this also. Add a tdc selftest to check correct validation of 'flows'. > > CC: Ivan Vecera > Fixes: ec97ecf1ebe4 ("net: sche

Re: [PATCH 2/3] switchdev: mrp: Remove the variable mrp_ring_state

2020-05-20 Thread Ivan Vecera
mrp_ring_state; /* MRP_RING_STATE */ > #endif > } u; > }; Acked-by: Ivan Vecera

[PATCH v5 bpf-next 14/15] samples/bpf: add sysroot support

2019-10-10 Thread Ivan Khoronzhuk
clean configure and install headers: make ARCH=arm defconfig make ARCH=arm headers_install build samples/bpf: make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- samples/bpf/ \ SYSROOT="path/to/sysroot" Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 5 +++

[PATCH v5 bpf-next 05/15] samples/bpf: use __LINUX_ARM_ARCH__ selector for arm

2019-10-10 Thread Ivan Khoronzhuk
quot;SMP is not supported" for armv7 and bunch of other errors are issued resulting to incorrect final object. Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 8 1 file changed, 8 insertions(+) diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index cf882e43648a..9b33e

[PATCH v5 bpf-next 10/15] samples/bpf: use target CC environment for HDR_PROBE

2019-10-10 Thread Ivan Khoronzhuk
No need in hacking HOSTCC to be cross-compiler any more, so drop this trick and use target CC for HDR_PROBE. Acked-by: Andrii Nakryiko Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/samples/bpf/Makefile b/samples

[PATCH v5 bpf-next 06/15] samples/bpf: drop unnecessarily inclusion for bpf_load

2019-10-10 Thread Ivan Khoronzhuk
Drop inclusion for bpf_load -I$(objtree)/usr/include as it is included for all objects anyway, with above line: KBUILD_HOSTCFLAGS += -I$(objtree)/usr/include Acked-by: Andrii Nakryiko Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v5 bpf-next 08/15] samples/bpf: base target programs rules on Makefile.target

2019-10-10 Thread Ivan Khoronzhuk
compilation (CC) with host build (HOSTCC), lets base samples on Makefile.target. It allows to cross-compile samples/bpf programs with CC while auxialry tools running on host built with HOSTCC. Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 135 ++- 1

[PATCH v5 bpf-next 13/15] samples/bpf: provide C/LDFLAGS to libbpf

2019-10-10 Thread Ivan Khoronzhuk
In order to build lib using C/LD flags of target arch, provide them to libbpf make. Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index a6c33496e8ca..6b161326ac67 100644

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-02 Thread Ivan Khoronzhuk
output" builds (O=)? I usually just build samples/bpf/ with: $ make V=1 O=/home/foo/build/bleh samples/bpf/ Björn Shouldn't README be updated? -- Regards, Ivan Khoronzhuk

Re: [PATCH iproute2 net-next v2 0/2] support for bridge fdb and neigh get

2019-09-30 Thread Ivan Vecera
s changed, 240 insertions(+), 5 deletions(-) > Works great. Thanks, Roopa. Tested-by: Ivan Vecera

[PATCH bpf-next 07/11] samples: bpf: add makefile.prog for separate CC build

2019-09-10 Thread Ivan Khoronzhuk
le.host. This allows later add cross-compilation to samples/bpf with minimum changes. Makefile.prog contains only stuff needed for samples/bpf, potentially can be reused and extended for other prog sets later and now needed only for unblocking tricky samples/bpf cross compilation. Signed-off

[PATCH bpf-next 03/11] samples: bpf: makefile: use --target from cross-compile

2019-09-10 Thread Ivan Khoronzhuk
For cross compiling the target triple can be inherited from cross-compile prefix as it's done in CLANG_FLAGS from kernel makefile. So copy-paste this decision from kernel Makefile. Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH bpf-next 01/11] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-10 Thread Ivan Khoronzhuk
echo should be replaced on echo -e to handle \n correctly, but instead, replace it on printf as some systems can't handle echo -e. Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/Makefile b/sample

[PATCH] be2net: eliminate enable field from be_aic_obj

2019-08-16 Thread Ivan Vecera
Adaptive coalescing is managed per adapter not per event queue so it does not needed to store 'enable' flag for each event queue. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/emulex/benet/be.h | 2 +- drivers/net/ethernet/emulex/benet/be_ethtool.c | 7 --- d

[PATCH bpf-next v2 0/3] xdpsock: allow mmap2 usage for 32bits

2019-08-15 Thread Ivan Khoronzhuk
e vmap along with page_address to avoid overkill - define mmap syscall trace5 for mmap if defined Ivan Khoronzhuk (3): libbpf: use LFS (_FILE_OFFSET_BITS) instead of direct mmap2 syscall xdp: xdp_umem: replace kmap on vmap for umem map samples: bpf: syscal_nrs: use mmap2 i

[PATCH iproute2] json: fix backslash escape typo in jsonw_puts

2019-07-17 Thread Ivan Delalande
Fixes: fcc16c22 ("provide common json output formatter") Signed-off-by: Ivan Delalande --- lib/json_writer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/json_writer.c b/lib/json_writer.c index 5004c181..88c5eb88 100644 --- a/lib/json_writer.c +++ b/lib/jso

[PATCH v9 net-next 2/5] net: ethernet: ti: davinci_cpdma: add dma mapped submit

2019-07-08 Thread Ivan Khoronzhuk
In case if dma mapped packet needs to be sent, like with XDP page pool, the "mapped" submit can be used. This patch adds dma mapped submit based on regular one. Signed-off-by: Ivan Khoronzhuk --- v8..v9: - fix warnings on arm64 caused by typos in type casting drivers/net/e

[PATCH v9 net-next 5/5] net: ethernet: ti: cpsw: add XDP support

2019-07-08 Thread Ivan Khoronzhuk
ndevs, based on switchdev for instance or else. In this case, driver can be modified like exposed here: https://lkml.org/lkml/2019/7/3/243 Acked-by: Jesper Dangaard Brouer Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/Kconfig| 1 + drivers/net/ethernet/ti/cpsw.c

[PATCH v9 net-next 0/5] net: ethernet: ti: cpsw: Add XDP support

2019-07-08 Thread Ivan Khoronzhuk
as drv data net: ethernet: ti: cpsw_ethtool: simplify slave loops Ivan Khoronzhuk (5): net: core: page_pool: add user refcnt and reintroduce page_pool_destroy net: ethernet: ti: davinci_cpdma: add dma mapped submit net: ethernet: ti: davinci_cpdma: allow desc split while down net

Re: [PATCH v6 net-next 1/5] xdp: allow same allocator usage

2019-07-04 Thread Ivan Khoronzhuk
On Wed, Jul 03, 2019 at 07:40:13PM +0200, Jesper Dangaard Brouer wrote: On Wed, 3 Jul 2019 13:18:59 +0300 Ivan Khoronzhuk wrote: First of all, it is an absolute requirement that each RX-queue have their own page_pool object/allocator. And this change is intendant to handle special case

Re: [PATCH] net: core: page_pool: add user refcnt and reintroduce page_pool_destroy

2019-07-02 Thread Ivan Khoronzhuk
On Tue, Jul 02, 2019 at 09:58:40PM +0300, Ivan Khoronzhuk wrote: On Tue, Jul 02, 2019 at 08:29:07PM +0200, Jesper Dangaard Brouer wrote: On Tue, 2 Jul 2019 18:21:13 +0300 Ivan Khoronzhuk wrote: On Tue, Jul 02, 2019 at 05:10:29PM +0200, Jesper Dangaard Brouer wrote: On Tue, 2 Jul 2019 17:56

Re: [PATCH] net: core: page_pool: add user refcnt and reintroduce page_pool_destroy

2019-07-02 Thread Ivan Khoronzhuk
On Tue, Jul 02, 2019 at 05:10:29PM +0200, Jesper Dangaard Brouer wrote: On Tue, 2 Jul 2019 17:56:13 +0300 Ivan Khoronzhuk wrote: On Tue, Jul 02, 2019 at 04:52:30PM +0200, Jesper Dangaard Brouer wrote: >On Tue, 2 Jul 2019 17:44:27 +0300 >Ivan Khoronzhuk wrote: > >> On Tue, Jul

Re: [net-next, PATCH 3/3, v2] net: netsec: add XDP support

2019-06-30 Thread Ivan Khoronzhuk
On Sun, Jun 30, 2019 at 07:47:45PM +0300, Ilias Apalodimas wrote: On Sun, Jun 30, 2019 at 07:41:28PM +0300, Ivan Khoronzhuk wrote: On Sun, Jun 30, 2019 at 07:32:14PM +0300, Ilias Apalodimas wrote: >On Sun, Jun 30, 2019 at 07:25:53PM +0300, Ivan Khoronzhuk wrote: >>On Sat, Jun 29, 2019

Re: [net-next, PATCH 3/3, v2] net: netsec: add XDP support

2019-06-30 Thread Ivan Khoronzhuk
On Sun, Jun 30, 2019 at 07:47:45PM +0300, Ilias Apalodimas wrote: On Sun, Jun 30, 2019 at 07:41:28PM +0300, Ivan Khoronzhuk wrote: On Sun, Jun 30, 2019 at 07:32:14PM +0300, Ilias Apalodimas wrote: >On Sun, Jun 30, 2019 at 07:25:53PM +0300, Ivan Khoronzhuk wrote: >>On Sat, Jun 29, 2019

Re: [net-next, PATCH 3/3, v2] net: netsec: add XDP support

2019-06-30 Thread Ivan Khoronzhuk
On Sun, Jun 30, 2019 at 07:34:17PM +0300, Ilias Apalodimas wrote: Hi Ivan, [...] >+ >+static int netsec_xdp(struct net_device *ndev, struct netdev_bpf *xdp) >+{ >+ struct netsec_priv *priv = netdev_priv(ndev); >+ >+ switch (xdp->command) { >+ case XDP_SETUP_P

Re: [net-next, PATCH 3/3, v2] net: netsec: add XDP support

2019-06-30 Thread Ivan Khoronzhuk
On Sun, Jun 30, 2019 at 07:32:14PM +0300, Ilias Apalodimas wrote: On Sun, Jun 30, 2019 at 07:25:53PM +0300, Ivan Khoronzhuk wrote: On Sat, Jun 29, 2019 at 08:23:25AM +0300, Ilias Apalodimas wrote: >The interface only supports 1 Tx queue so locking is introduced on >the Tx queue if

Re: [net-next, PATCH 3/3, v2] net: netsec: add XDP support

2019-06-30 Thread Ivan Khoronzhuk
do_ioctl = netsec_netdev_ioctl, + .ndo_xdp_xmit = netsec_xdp_xmit, + .ndo_bpf= netsec_xdp, }; static int netsec_of_probe(struct platform_device *pdev, -- 2.20.1 -- Regards, Ivan Khoronzhuk

Re: [net-next, PATCH 3/3, v2] net: netsec: add XDP support

2019-06-30 Thread Ivan Khoronzhuk
ddress= eth_mac_addr, .ndo_validate_addr = eth_validate_addr, .ndo_do_ioctl = netsec_netdev_ioctl, + .ndo_xdp_xmit = netsec_xdp_xmit, + .ndo_bpf= netsec_xdp, }; static int netsec_of_probe(struct platform_device *pdev, -- 2.20.1 -- Regards, Ivan Khoronzhuk

  1   2   3   4   5   6   7   >