Re: [PATCH] e1000e: use proper #include guard name in hw.h

2021-03-02 Thread gre...@linuxfoundation.org
On Tue, Mar 02, 2021 at 01:37:59AM +, Nguyen, Anthony L wrote: > On Sat, 2021-02-27 at 10:58 +0100, Greg Kroah-Hartman wrote: > > The include guard for the e1000e and e1000 hw.h files are the same, > > so > > add the proper "E" term to the hw.h file for the e1000e driver. > > There's a patch i

Re: [PATCH v10 01/20] dlb: add skeleton for DLB driver

2021-02-17 Thread gre...@linuxfoundation.org
On Thu, Feb 18, 2021 at 07:34:31AM +, Chen, Mike Ximing wrote: > > > > -Original Message- > > From: Mike Ximing Chen > > Sent: Wednesday, February 10, 2021 12:54 PM > > To: netdev@vger.kernel.org > > Cc: da...@davemloft.net; k..

Re: [RFC] debugfs: protect against rmmod while files are open

2020-10-09 Thread gre...@linuxfoundation.org
On Fri, Oct 09, 2020 at 10:56:16AM +, David Laight wrote: > From: Johannes Berg > > Sent: 09 October 2020 11:48 > > > > On Fri, 2020-10-09 at 12:41 +0200, Johannes Berg wrote: > > > > > If the fops doesn't have a release method, we don't even need > > > to keep a reference to the real_fops, w

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-08 Thread gre...@linuxfoundation.org
On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote: > On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote: > [..] > > All stated above is my opinion, it can be different from yours. > > Yes, but we need to converge to move this forward. Jason was involved > in the current organization

Re: [PATCH] net/packet: fix overflow in tpacket_rcv

2020-09-04 Thread gre...@linuxfoundation.org
On Fri, Sep 04, 2020 at 02:22:46PM +, Nuernberger, Stefan wrote: > On Fri, 2020-09-04 at 16:16 +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 04, 2020 at 03:30:52PM +0200, Stefan Nuernberger wrote: > > > > > > From: Or Cohen > > > > > > Using tp_reserve to calculate netoff can overflow as

Re: [net-next v4 01/12] Implementation of Virtual Bus

2020-05-21 Thread gre...@linuxfoundation.org
On Thu, May 21, 2020 at 02:57:55PM +, Parav Pandit wrote: > Hi Greg, Jason, > > On 5/20/2020 12:32 PM, Jeff Kirsher wrote: > > From: Dave Ertman > > > > > +static const > > +struct virtbus_dev_id *virtbus_match_id(const struct virtbus_dev_id *id, > > + stru

Re: [EXTERNAL] Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 11:22:58AM +, Badel, Laurent wrote: > Dear Greg, > > Thanks for your reply and sorry for my mistake. > Looks to me like the issue is the commit hash which should be 12 chars. > Does that mean I need to fix and resend the whole thing to everyone? Yes please, never fo

Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 09:03:32AM +, Badel, Laurent wrote: > Description: This patch reverts commit 1b0a83ac04e3 > ("net: fec: add phy_reset_after_clk_enable() support") > which produces undesirable behavior when PHY interrupts are enabled. > > Rationale: the SMSC LAN8720 (and possibly othe

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-05 Thread gre...@linuxfoundation.org
On Sat, Oct 05, 2019 at 09:28:05AM +0300, Leon Romanovsky wrote: > On Fri, Oct 04, 2019 at 05:46:15PM -0700, Jeff Kirsher wrote: > > On Fri, 2019-10-04 at 23:45 +, Jason Gunthorpe wrote: > > > On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote: > > > > > > > > > + if (ldev->version.

Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions

2019-09-27 Thread gre...@linuxfoundation.org
On Fri, Sep 27, 2019 at 02:28:20PM +, Saleem, Shiraz wrote: > > Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions > > > > On Thu, Sep 26, 2019 at 07:49:33PM +, Saleem, Shiraz wrote: > > > > Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility > > > > defi

Re: [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

2019-09-26 Thread gre...@linuxfoundation.org
On Thu, Sep 26, 2019 at 11:39:22PM +, Nguyen, Anthony L wrote: > On Thu, 2019-09-26 at 20:05 +0200, Greg KH wrote: > > On Thu, Sep 26, 2019 at 09:45:00AM -0700, Jeff Kirsher wrote: > > > From: Tony Nguyen > > > > > > The RDMA block does not advertise on the PCI bus or any other bus. > > > >

Re: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated

2019-09-26 Thread gre...@linuxfoundation.org
On Thu, Sep 26, 2019 at 07:49:44PM +, Saleem, Shiraz wrote: > > Subject: Re: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated > > > > On Thu, Sep 26, 2019 at 09:45:19AM -0700, Jeff Kirsher wrote: > > > From: Shiraz Saleem > > > > > > Mark i40iw as deprecated/obsolete. > > > > > > irdma is the

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread gre...@linuxfoundation.org
On Thu, Sep 26, 2019 at 04:55:12PM +, Jason Gunthorpe wrote: > On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > > +int i40iw_probe(struct platform_device *pdev) > > +{ > > + struct i40e_peer_dev_platform_data *pdata = > > + dev_get_platdata(&pdev->dev); > > + struct

Re: [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread gre...@linuxfoundation.org
On Tue, Aug 06, 2019 at 07:41:57PM +, Saeed Mahameed wrote: > On Tue, 2019-08-06 at 18:11 +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic > > should > > never do something

Re: [PATCH] staging: isdn: To make hysdn_proc_entry static.

2019-06-09 Thread gre...@linuxfoundation.org
On Sun, Jun 09, 2019 at 12:24:59AM +, Rishiraj Manwatkar wrote: > Made hysdn_proc_entry static as suggested by Sparse tool. Why is this indented? > > Signed-off-by: Rishiraj Manwatkar > --- > drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] rpc: properly check debugfs dentry before using it

2019-02-12 Thread gre...@linuxfoundation.org
On Tue, Feb 12, 2019 at 08:52:53PM +, Schumaker, Anna wrote: > On Tue, 2019-02-12 at 19:27 +0100, Greg Kroah-Hartman wrote: > > debugfs can now report an error code if something went wrong instead of > > just NULL. So if the return value is to be used as a "real" dentry, it > > needs to be che

Re: [patch net] devlink: convert occ_get op to separate registration

2018-04-11 Thread gre...@linuxfoundation.org
On Tue, Apr 10, 2018 at 08:43:31PM +, Sasha Levin wrote: > >Bots are starting to overwhelm actual content from human beings > >on this list, and I want to put my foot on the brake right now > >before it gets even more out of control. > > I think we're just hitting the limitations of using a ma

Re: Bluetooth: Prevent stack info leak from the EFS element.

2018-01-04 Thread gre...@linuxfoundation.org
On Tue, Jan 02, 2018 at 12:26:15PM -0800, Guenter Roeck wrote: > On Fri, Dec 08, 2017 at 03:14:47PM +0100, gre...@linuxfoundation.org wrote: > > From: Ben Seri > > > > In the function l2cap_parse_conf_rsp and in the function > > l2cap_parse_conf_req the following v

Re: linux kernel – 4.4.45 : VPN test failure

2017-10-25 Thread gre...@linuxfoundation.org
On Wed, Oct 25, 2017 at 12:49:09PM +, Nanjappa, Gangadhar wrote: > Hi All, > Using linux kernel – 4.4.45 (Blurry Fish Butt), VPN test fails. If I > revert the attached five patches, VPN test passes. But I’m not > supposed to revert the patches to get the test passed. I’m analyzing > the patches

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-08 Thread gre...@linuxfoundation.org
On Wed, Mar 08, 2017 at 09:42:09AM +, Reshetova, Elena wrote: > > On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid ac

Re: [PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread gre...@linuxfoundation.org
On Thu, Jan 05, 2017 at 07:08:23PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Thursday, January 5, 2017 10:29 AM > > To: KY Srinivasan > > Cc: Stephen

Re: [PATCH net] hyper-v: Add myself as additional MAINTAINER

2017-01-05 Thread gre...@linuxfoundation.org
c: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > > gre...@linuxfoundation.org; Stephen Hemminger > > > > Subject: [PATCH net] hyper-v: Add myself as additional MAINTAINER > > > > Update the Hyper-V MAINTAINERS to include myself. > > > > Signed-off-

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-21 Thread gre...@linuxfoundation.org
On Sun, Nov 20, 2016 at 06:30:19AM +, Levy, Amir (Jer) wrote: > On Fri, Nov 18 2016, 12:07 PM, gre...@linuxfoundation.org wrote: > > On Fri, Nov 18, 2016 at 08:48:36AM +, Levy, Amir (Jer) wrote: > > > > BTW, it is quite a shame that the Thunderbolt firmware version

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-18 Thread gre...@linuxfoundation.org
On Fri, Nov 18, 2016 at 08:48:36AM +, Levy, Amir (Jer) wrote: > > BTW, it is quite a shame that the Thunderbolt firmware version can't > > be read from Linux. > > > > This is WIP, once this patch will be upstream, we will be able to focus more > on aligning Linux with the Thunderbolt feature

Re: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-09-30 Thread gre...@linuxfoundation.org
On Fri, Sep 30, 2016 at 08:37:36AM +, Levy, Amir (Jer) wrote: > On Fri, Sep 30 2016, 09:40 AM, David Miller wrote: > > From: Greg KH > > Date: Fri, 30 Sep 2016 08:30:05 +0200 > > > > > On Fri, Sep 30, 2016 at 01:55:55AM -0400, David Miller wrote: > > >> From: Amir Levy > > >> Date: Wed, 28 S

Re: [PATCH v11 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-05-18 Thread gre...@linuxfoundation.org
On Thu, May 19, 2016 at 12:59:09AM +, Dexuan Cui wrote: > > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > > Behalf > > Of Dexuan Cui > > Sent: Tuesday, May 17, 2016 10:46 > > To: David Miller > > Cc: o...@aepfle.de; gre...@linu

Re: When will net-next merge with linux-next?

2016-03-15 Thread gre...@linuxfoundation.org
On Wed, Mar 16, 2016 at 01:58:50AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, March 15, 2016 23:06 > > To: Dexuan Cui > > Cc: David Miller ; netdev@vger.kernel.org; KY > > Srinivasan ; Haiyan

Re: When will net-next merge with linux-next?

2016-03-15 Thread gre...@linuxfoundation.org
On Tue, Mar 15, 2016 at 11:11:34AM +, Dexuan Cui wrote: > I'm wondering whether (and when) step 2 will happen in the next 2 weeks, > that is, before the tag 4.6-rc1 is made. > If not, I guess I'll miss 4.6? You missed 4.6 as your patch was not in any of our trees a few days before 4.5 was rele

Re: When will net-next merge with linux-next?

2016-03-14 Thread gre...@linuxfoundation.org
On Mon, Mar 14, 2016 at 06:09:41AM +, Dexuan Cui wrote: > Hi David, > I have a pending patch of the hv_sock driver, which should go into the > kernel through the net-next tree: > https://lkml.org/lkml/2016/2/14/7 > > The VMBus side's supporting patches of hv_sock have been in Greg's tree > and