Ok, I will respin the failed patches.
Thanks,
-Dhananjay
On Sat, 12 Jan 2008, Jeff Garzik wrote:
> patch conflicted with
>
> commit 1706287f6eb58726a9a0e5cbbde87f49757615e3
> Author: David S. Miller <[EMAIL PROTECTED]>
> Date: Mon Jan 7 20:51:29 2008 -0800
>
> [NETXEN]: Fix ->poll() done
lades caused by buggy
(non) processing rx status ring.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic.h
===
--- netdev-2.6.orig/drivers/net/netxen/netxen_nic.h
+++ netdev-2.6/
I agree for tx desc, the compiler would optimize.
But for rx (status) desc, I didn't like multiple le64_to_cpu()
for extracting various fields out of same status dword.
-Dhananjay
On Wed, 26 Dec 2007, Al Viro wrote:
> On Wed, Dec 26, 2007 at 10:23:59AM -0800, [EMAIL PROTECTED] wrote:
> > This
Supposedly I had 2.6.24-rc2 as base for the patchset, but looks like it
had some stale code. I'll regenrate series on a fresh checkout.
-Dhananjay
On Sat, 22 Dec 2007, Jeff Garzik wrote:
> Patch does not apply to 2.6.24-rc.
>
> Was this "bug fix" series meant for 2.6.25?
>
> Jeff
>
>
Probably I need to clean up much more junk like that from days before I
took over. I recently cleaned up a bit of rx and tx code, which is more
frequently executed.
The last one (byte swapping) is serious and I am gonna take care of that
in next patch.
Thanks,
-Dhananjay
On Sun, 23 Dec 2007,
This looks good to me, I might chop off these #if 0 'ed functions in
my next round of patches.
Acked-by: Dhananjay Phadke <[EMAIL PROTECTED]>
On 11/5/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> This patch contains the following cleanups:
> - static functions in .c fi
That "00 0e 1e ..." is netxen's mac address, so sounds like the NIC is
dumping a frame in the skb already freed (and poisoned) by the stack.
I suppose -RT kernels preempt the softirq, giving a chance for this race.
The netxen driver doesn't seem to clear the mapped address of the skb in
rx descrip
Resubmitting the patch.
This patch improves ethtool support for printing correct ring statistics,
segmentation offload status, etc.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen
oops, ok regenerating patch 3 only.
On Fri, 31 Aug 2007, Jeff Garzik wrote:
> [EMAIL PROTECTED] wrote:
> > +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data)
> > +{
> > + struct netxen_adapter *adapter = netdev_priv(dev);
> > + adapter->rx_csum = 0;
> > + return 0;
> > +}
Some leftover code that makes use of adapter->lock in tx_timeout function,
which resets the interface under this lock. In close() when the workqueue
is flushed, prints the warning about sleeping with interrupts disabled
(when spinlock debug is enabled). The lock was required with private netxen
IOC
adapter
> on powerpc blades. This patch also fixes a bug that PCI resources are not
> freed if dma watchdog shutdown failed. The dma watchdog poll messages
> during module unload are also suppressed.
>
> Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
> Signed-off-by: Mi
Jeff,
Any chance of these patches getting committed soon?
Thanks,
-Dhananjay Phadke
On 7/21/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
These patches include fix for problem with 2nd port of multiport adapters
on IBM blades. Also improves interrupt handling for multiport ad
Please ignore this patch. There's one more patch in the series. I will
send them together.
Thanks,
-Dhananjay
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The MSI error wasn't fatal, so it was suppressed in recent fixes for
2.6.22-rc7. The driver in 2.6.21 had many bugs, but I ain't sure if
recent fixes are going to be pulled in Fedora kernel.
-Dhananjay
Ben Greear wrote:
> Hello!
>
> I just got some Netxen 10Gbe CX4 adapters and put them into fre
Yes those functions are large enough to be de-inlined. I would like to
shrink those to functions, by replacing the switch blocks with a simple
macros, since the mask registers are contiguous.
Will repost a patch based on your patch, after a bit of testing.
Thanks,
-Dhananjay
Stephen Hemminger wr
Resending patch 3/3 only.
These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Mil
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.
Signed-off-by: Dhananjay Phadke<[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Signed
These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Removed signal_pending checks during init, per Jeff's suggestion.
drivers/net/netxen/netxen_nic.h | 180 +++---
drivers/net/netxen/netxen_nic_hdr.h |2 +
drivers/net/netxen/netxen_nic_hw.c | 33 --
drivers/net/netxen/netxen_nic_init.c |
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off by: Mil
These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off by: Mil
Resending with changes suggested.
--
Dhananjay Phadke
NetXen Inc.
drivers/net/netxen/netxen_nic.h | 177 +++---
drivers/net/netxen/netxen_nic_hdr.h |2 +
drivers/net/netxen/netxen_nic_hw.c | 39 +--
drivers/net/netxen/netxen_nic_init.c
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.
Signed-off-by: Dhananjay Phadke<[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Signed
This stage is safe to bail out on signal. It's initializing about a
hundred registers
and trying to guaranty by retrying, so can get stretched too much on faulty h/w.
-Dhananjay
On 7/1/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
While strictly this is true, I strongly urge the use of
non-interru
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off by: Mil
These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Sending reworked patches based on Michael's feedback (originally sent
by Mithlesh Thukral). These patches address interrupt mask issues on
multiport adapters, as well as stability issues on powerpc blades.
--
Dhananjay Phadke
NetXen Inc.
drivers/net/netxen/netxen_nic.h |
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.
Signed-off-by: Dhananjay Phadke<[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Signed
There's change of guard from NetXen side. I have reworked Mithlesh's
original patches based on Michael's feedback. Will be sending out shortly.
--
Dhananjay Phadke
NetXen Inc.
On 6/22/07, Mithlesh Thukral <[EMAIL PROTECTED]> wrote:
Hi All,
I will be sending updates
Mithlesh,
You don't initialize max_mc_count anywhere. The multicast address pool
can hold 16 addresses for ports {0,1} and 4 for ports {2,3}. You should
have following line in the probe routine.
> adapter->max_mc_count = (adapter->portnum > 1) ? 4 : 16;
--
Dhananjay
31 matches
Mail list logo
