Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-07-08 Thread Zhivich, Michael
On 7/2/20, 2:08 PM, "Josh Hunt" wrote: > > On 7/2/20 2:45 AM, Paolo Abeni wrote: > > Hi all, > > > > On Thu, 2020-07-02 at 08:14 +0200, Jonas Bonn wrote: > >> Hi Cong, > >> > >> On 01/07/2020 21:58, Cong Wang wrote: > >>> On Wed, Jul 1, 2020 at 9:05 AM Cong Wang wrote: > On Tue, Jun 30, 202

Re: [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant

2019-04-08 Thread Zhivich, Michael
On 4/8/19, 1:55 PM, "Andrew Lunn" wrote: >On Mon, Apr 08, 2019 at 10:48:44AM -0400, Michael Zhivich wrote: >> This patch series addresses 2 related issues: >> >> 1. ethtool_validate_speed() triggers a "signed-unsigned comparison" >> warning due to type difference of SPEED_UNKNOWN constant (int)

Re: [PATCH] ethtool: fix SPEED_UNKNOWN definition to avoid signed-unsigned comparison

2019-04-03 Thread Zhivich, Michael
On 4/2/19, 4:26 PM, "David Miller" wrote: > From: Michael Zhivich > Date: Mon, 1 Apr 2019 13:14:28 -0400 > >> When building C++ userspace code that includes ethtool.h >> with "-Werror -Wall", g++ complains about signed-unsigned comparison in >> ethtool_validate_speed() due to definition of SPEE