[PATCH bpf-next] selftests/bpf: fix error printing in test_devmap()

2018-12-21 Thread Xiaozhou Liu
As a simple fix, just print the correct map type. Signed-off-by: Xiaozhou Liu --- tools/testing/selftests/bpf/test_maps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c index 9c79ee017df3

Re: [PATCH net] soreuseport: use RCU_INIT_POINTER() when NULLing

2018-12-12 Thread Xiaozhou Liu
On Wed, Dec 12, 2018 at 05:08:45AM -0800, Eric Dumazet wrote: > > It is _not_ faster. > > Just different ways to do the exact same thing. > > For some reason you missed this two years old commit : > > > commit 3a37f7275cda5ad25c1fe9be8f20c76c60d175fa > Author: Paul E. McKenney > Date: Sun

[PATCH net] soreuseport: use RCU_INIT_POINTER() when NULLing

2018-12-12 Thread Xiaozhou Liu
Use RCU_INIT_POINTER() instead of rcu_assign_pointer() to NULL out the pointer because it is a bit faster. Signed-off-by: Xiaozhou Liu --- net/core/sock_reuseport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c index

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-12-06 Thread Xiaozhou Liu
On Thu, Nov 29, 2018 at 11:42:11AM +0100, Miguel Ojeda wrote: > Exactly, thanks a lot for clarifying it up (we should put this in the > commit message, I would say). That also answers my question: it is > clear everything should be back into __KERNEL__. The only worry is > that the v4.19 release c

[PATCH] netfilter: update comment about get_unique_tuple()

2018-11-28 Thread Xiaozhou Liu
`__ip_conntrack_confirm' in the comment is a bit confusing since it has long been replaced with __nf_conntrack_confirm in the code. Just update the comment. Signed-off-by: Xiaozhou Liu --- net/netfilter/nf_nat_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] Compiler Attributes: move kernel-only attributes into __KERNEL__

2018-11-28 Thread Xiaozhou Liu
Hi Miguel, On Wed, Nov 28, 2018 at 06:35:18PM +0100, Miguel Ojeda wrote: > Hi Xiaozhou, > > On Wed, Nov 28, 2018 at 3:09 PM Xiaozhou Liu > wrote: > > > > Attributes such as `__gnu_inline' are meant to be used within the > > kernel. When userspace s