Re: [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem

>> >> The eth-phy-activity trigger uses the blink_set which I think uses the >> >> hardware acceleration if available. I am not sure how to handles LEDs >> >> which does not have hardware acceleration for this (eth-phy-activity) >> >> trigger. >> > >> > We want the LED to blink on activity, real pa

Re: [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem

On Wed, Mar 23, 2016 at 10:10 PM, Andrew Lunn wrote: > On Wed, Mar 23, 2016 at 09:24:00PM +0100, Vishal Thanki wrote: >> Hi, >> >> > My suggestion was that the hardware needs to control the LEDs. You >> > have software doing it. You might be able to do this wi

Re: [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem

Hi, > My suggestion was that the hardware needs to control the LEDs. You > have software doing it. You might be able to do this with the PHY > state machine for link. But activity is never going to be accepted if > software control. > > The LED trigger attached to an LED should be used to configur

[PATCH 2/3] net: phy: at8030: Expose the Link and Activity LEDs

Expose these LEDs by means of a platform device which can be controlled by a suitable LED driver. Signed-off-by: Vishal Thanki --- drivers/net/phy/at803x.c | 55 +- include/linux/phy/at803x.h | 45 + 2 files

[PATCH 1/3] net: phy: Add ethernet PHY LED triggers

Add the LED triggers for ethernet PHY link and activity status. The triggers are set mainly based on the PHY state machine. Signed-off-by: Vishal Thanki --- drivers/net/phy/Kconfig | 7 + drivers/net/phy/Makefile | 1 + drivers/net/phy/phy.c| 20 +++-- drivers/net

[PATCH 0/3] Control ethernet PHY LEDs via LED subsystem

complete. Thanks, Vishal Vishal Thanki (3): net: phy: Add ethernet PHY LED triggers net: phy: at8030: Expose the Link and Activity LEDs led: at8030: Add LED driver for AT8030 ethernet PHY drivers/leds/Kconfig | 7 ++ drivers/leds/Makefile| 1 + drivers/leds/leds-at803x.c

[PATCH 3/3] led: at8030: Add LED driver for AT8030 ethernet PHY

This patch adds support for controlling the Link and Activity LED of AT8030 ethernet PHY through LED subsystem. Signed-off-by: Vishal Thanki --- drivers/leds/Kconfig | 7 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-at803x.c | 158

Re: [PATCH] net: phy: at803x: Add support to control PHY LEDs

Hi, On Thu, Mar 17, 2016 at 07:07:12PM +0100, Vishal Thanki wrote: > > > > They might not be on/off controllable individually, but you can often > > set them to show Packet RX, Packet TX, Link, speed, etc, in a > > reasonably flexible way. So you could have LED trigg

Re: [PATCH] net: phy: at803x: Add support to control PHY LEDs

On Thu, Mar 17, 2016 at 5:59 PM, Florian Fainelli wrote: > On 17/03/16 07:50, Andrew Lunn wrote: >> On Thu, Mar 17, 2016 at 02:59:07PM +0100, Vishal Thanki wrote: >>> The LEDs can be turned on and off by a sysfs interface >>> now. Write 0 to "led_enable" file

Re: [PATCH] net: phy: at803x: Add support to control PHY LEDs

> > They might not be on/off controllable individually, but you can often > set them to show Packet RX, Packet TX, Link, speed, etc, in a > reasonably flexible way. So you could have LED triggers mapping to > these functionalities. The user can then pick the trigger for the LED. > > Actually, the

[PATCH] net: phy: at803x: Add support to control PHY LEDs

The LEDs can be turned on and off by a sysfs interface now. Write 0 to "led_enable" file to turn off the LEDs and write 1 to turn on. The support is experimental and can be enabled by kernel configuration option. Signed-off-by: Vishal Thanki --- drivers/net/phy/Kconfig | 7 + d

[PATCH] Add support to control PHY LEDs

Hi all, We had a requirement to disable the PHY link LEDs during system standby mode without turning off the ethernet module. To achieve that, I have prepared the sysfs interface turn on/off the PHY link LEDs. Please suggest if there is any better way to achieve this. Thanks, Vishal Vishal