Re: [PATCH net] ixgbe: napi_poll must return the work done

2016-06-15 Thread Venkatesh Srinivas
t) > if (!test_bit(__IXGBE_DOWN, &adapter->state)) > ixgbe_irq_enable_queues(adapter, BIT_ULL(q_vector->v_idx)); > > - return 0; > + return min(work_done, budget - 1); > } > > /** Reviewed-by: Venkatesh Srinivas The same bit of code appe

Re: [PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

2016-03-19 Thread Venkatesh Srinivas
noise (+0.6% - +1% bandwidth). What tests did you see a 2-3% win on? Do you think its worth modifying add_recvbuf_small() to use napi_alloc_skb() when called from Rx NAPI (virtnet_receive)? Tested-by: Venkatesh Srinivas Thanks, -- vs;

Re: [net-next v2] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

2016-03-19 Thread Venkatesh Srinivas
align() invocation in > add_recvbuf_small(), suggested by Venkatesh Srinivas > --- > drivers/net/virtio_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index fb0eae4..100e039 100644 > --- a/drivers/net/

Re: [PATCH v2] vhost: replace % with & on data path

2015-12-04 Thread Venkatesh Srinivas
On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin wrote: > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin > --- The generated code switches from DIV -> masking, source is clearer as well. Tested-